Adam Fidel

Results 8 comments of Adam Fidel

> @danhoeflinger: Should we instead align our _PSTL_UDR_PRESENT with how others treat it (defined on undefined) and then check `defined(_PSTL_UDR_PRESENT)`? Are you suggesting that we change oneDPL's `pstl_config.h` to make...

> @danhoeflinger One option is to make a macro: `_ONEDPL_DEFINED_AND_NOT_ZERO(FLAG)` which could be reused for something like this and have the workaround in one place. However, again I don't know...

I was curious if the three provided functions in the macro were enough to cover all of the cases to compare. But I enumerated them and it does seem like...

I do not have much to add, but I have installed GCC 9/10 and have confirmed that the following program does not compile on the main branch with gcc9/gcc10 and...

> I do think it would be best if we better understand the compiler warning messages regarding generic address space operations we are seeing before merging. > > For context...

Thanks all for the reviews! @danhoeflinger and @dmitriy-sobolev, I will create GH issues to address the next steps that you have mentioned in your approvals.

I looked through the implementations of the new operators and they seem good to me. Since in practice the `sycl_iterator` class provided `operator

I agree that commenting out the `if (0)` branch would be an acceptable alternative to what is there currently.