Adam Shannon

Results 394 comments of Adam Shannon

After adding a `go.mod` file there's just one compile error. Do you know what to do? ``` $ gotest ./... # github.com/moovweb/rubex chelper.c:26:11: error: call to undeclared function 'onig_new_default'; ISO...

@rjeczalik I've got a feeling that this was [accidently overridden](https://github.com/Banno/terraform-provider-marathon/pull/41) for the case when we want to watch the deployment. Rather, we should probably have a different timeout when watching...

It looks like go-marathon is pulling in `github.com/donovanhide/eventsource` which is using server push to wait on events. I'd have to check, but is `http.Client` looking at `Timeout` to close the...

We likely should create a different http client for reading off the event stream then. https://github.com/Banno/terraform-provider-marathon/blob/master/marathon/resource_marathon_app.go#L413 The provider's client could be used for single get/post/put/delete events.

This should probably be one we take over as there are several notable projects using this. Has there ever been a security audit? - Usage in [Docker (moby/moby)](https://github.com/moby/moby/blob/master/pkg/filenotify/filenotify.go#L6) - Usage...

The link looks to be https://github.com/jonboulle/clockwork

I don't think we should adopt this project. As Tim said reflection is hidden underneath and the functions may not be completely correct for any given business case. The [ISO...

Aside from yesterday, there were 7 issues updated in 2018. Source: https://github.com/fatih/color/issues?q=is%3Aissue+is%3Aclosed+sort%3Aupdated-desc If there are open bugs then I'm fine forking and helping fix, but I'm unsure if there are....

Wouldn't we have to get contributors from before we adopted a project to sign off on a license change too?

FWIW I've had the CNCF/Kubernetes CLA fail multiple separate times, so much so that I've been unable to commit single line changes to upstream Kubernetes. Placing a burden on contributions...