help-requests icon indicating copy to clipboard operation
help-requests copied to clipboard

asaskevich/govalidator

Open tariq1890 opened this issue 5 years ago • 2 comments

Where is the project currently hosted?

https://github.com/asaskevich/govalidator

When was the project's last activity?

Jul 20, 2018

Does the project have a maintainer, or a maintainer looking for someone to take over the project?

No

What active projects replicate the popular functionality of this project, if any?

None that I know of.

Are there any outstanding critical bugs that result in the library being totally unusable or insecure?

https://github.com/asaskevich/govalidator/issues/266. While the fix has been merged into master for this. A release hasn't yet been cut.

tariq1890 avatar Apr 23 '19 23:04 tariq1890

Speaking personally, :-1:. Whenever I see this mentioned in the community, I advocate for avoiding it and to instead write a purpose-built validation function. It's a complex dependency that utilizes reflection. Adopting this in to your project increases the cognitive burden, as you and any contributors now need to learn how it works and the nuances of that. A function you write and test is much more clear and approachable.

How do other Gofrs feel?

theckman avatar Apr 24 '19 00:04 theckman

I don't think we should adopt this project. As Tim said reflection is hidden underneath and the functions may not be completely correct for any given business case.

The ISO 3166 and ISO 4217 codes haven't been updated for several years either.

adamdecaf avatar May 01 '19 15:05 adamdecaf