Adam Johnson comments

Results 507 comments of


                                            Adam Johnson

Extend C41x to detect for _ in list(dict.values())

Hi, Yes, we could do this. I think it would want another code. I don't have time to look into this right now, but if you make a PR I'll...

Automatically run checks at the start of tests

Running it manually _before_ tests begin but _after_ the test database has been created is troublesome, that's why I was thinking patching it into the database creation logic in `pytest-django`...

Automatically run checks at the start of tests

Also there isn't really any concern about slowing down test run, even on the full django test suite with its hundreds of models etc. it takes about 1s to run...

Automatically run checks at the start of tests

@blueyed the most of the time you're seeing for `manage.py check` is importing the modules etc. all over again. If you work it into a test run, pre-tests, it's rather...

a patchy interface to allow use in contexts

Yeah I don't think replacing `__code__` with something that does dispatch is possible. Anyway... why do you want this?

Windows line endings under Mingw as installed by Git

Sounds to me like we should normalize the source and the patch to `\n` line endings before saving and calling `patch`.

Windows line endings under Mingw as installed by Git

``` ¯\_(ツ)_/¯ ```

`patch: **** malformed patch at line xxx` error

It looks like your `patch` utility requires the header lines - those before the `@@` that specify the filename etc., which step 4 of the "How to Create a Patch"...

Rewriting within f-strings

> an idea though, since we have a format string parser already, is to identify the f-strings during a tokenize pass and rewrite each of their format chunks separately? it...

Sentry has ~8% overhead in Django test suites

I'm "the other engineer at another company". 😄