Adam Johnson

Results 507 comments of Adam Johnson

It is slower... [wikipedia](https://en.wikipedia.org/wiki/Zopfli): > Under default settings, the output of Zopfli is typically 3–8% smaller than zlib's maximum compression, but takes around 80 times longer. Whitenoise already adds a...

Okay. I think the best course of action right now is to leave this open, and if others show support for the feature then we can look into it.

There’s an FAQ already on avoiding the full scan by enabling `WHITENOISE_AUTOREFRESH`: [WhiteNoise makes my tests run slow!](https://whitenoise.readthedocs.io/en/latest/django.html#whitenoise-makes-my-tests-run-slow). Any PRs to surface this information better are very welcome. But since...

> In my experience, it’s usual to not add whitenoise to middleware for unit test settings. I would not recommend this, the more drift you introduce between test and production...

I’m not a huge expert, I just pattern-matched the problem to the one I’ve seen before. New instances per test does sound like it will cause slowness, yes. Yes, Django...

> that's an annoying barrier to entry, can you file one for me? It’s not a very high barrier. Log in with GitHub at https://code.djangoproject.com/ , click “New ticket”, fill...

Lint error: ``` Error: ./django/views/csrf.py:26:5: F401 'django.middleware.csrf.REASON_BAD_ORIGIN' imported but unused ``` Set up pre-commit for yourself: https://docs.djangoproject.com/en/dev/internals/contributing/writing-code/coding-style/#pre-commit-checks

Bump. I'd like to upgrade to keep up to date.

The link on the Github repo description also needs updating.