Aakansha Doshi

Results 504 comments of Aakansha Doshi

> We should be building docs (CI) only when there's any change in `docs/`. That's what happens now, isnt' it?

> @dwelle Could you please approve the workflow? should work now

> ### API for sidebar headers > When rendering multiple tabs, you may want to have a different sidebar header for each tab. For example, a sidebar that contains `library`...

> render default header I didn't get you, you mean render default header if not passed ?

> Package seems to work, but for some reason it's breaking the example https://excalidraw-package-example-git-fork-aloento-master-excalidraw.vercel.app/ checking

So with this change the integration is broken in browser since there are two new externals which are needed now "react-dom/client", "react/jsx-runtime" for which looks like there are no direct...

> @Aloento @ad1992 I'd actually love to merge this if we figure out the way to fix the `react-dom/client` & `react/jsx-runtime` thing Yep this was breaking in browser, once that's...

Oops, this is a typo!, thanks for catching @paudrow cc @maielo @barnabasmolnar

As a user I do understand where this is coming from and I do agree we should improve this behaviour, specially when you have some drawing behind the sidebar its...