Aakansha Doshi comments

Results 503 comments of


                                            Aakansha Doshi

Run pre-commit hook before the prompt

@dkimot @LinusU I still think we should not allow the cli to run if pre-commit hook fails. what do you guys think ?

Run pre-commit hook before the prompt

We shouldn't allow the the cli to run if pre-commit hook fails and also if files are not added. Did everyone agree on this ? Is anyone working on this...

Run pre-commit hook before the prompt

@dkimot @LinusU can I take this up ?

preventSubmit prop not working

@ryanhyslop Sorry for the delayed response. I have added a failing test and the fix. Can you please check https://github.com/olahol/react-tagsinput/pull/168 I agree that the prop name can be better something...

preventSubmit prop not working

@ryanhyslop any updates ?

Fix #142

@olahol @ryanhyslop please look in to this

chore: Dedupe package dependencies and webpack configs.

Merging, thanks @DanielJGeiger 🎉

feat: Added one more stroke width preset (#3693)

I feel adding one more option for stroke is not really needed, however we might want to think about updating the thing stroke from `1` to `0.5` instead if needed....

[Not For Merge]: Rollup of #2993

HI @DanielJGeiger, sorry for not being responsive on your PR. Before we start the review I was thinking about a plugin like integration where users can install the extra add-ons...

feat: Support custom extensions of `ExcalidrawElement` in @excalidraw/excalidraw

@DanielJGeiger do you mind adding some notes in the PR description on what this PR aims for so its easier to start reviewing ?