David Baker comments

Results 160 comments of


                                            David Baker

LinkView "active" class not always applied after retried transitions

That's quite helpful, yep I see it too ;-)

Redirecting a transition to same route with different query params does not work unless transition is aborted before

@jelhan which version of Ember are you seeing this in?

Ember is minified even in development

@boris-petrov which browser are you using in development? Potentially a difference in handling debugging post pretty-printing?

Migrate `@import` rules (CSS)

@MelSumner to clarify, this is for the tests, correct?

Skip checking the source for synthetic attributes to prevent warning.

I've been helping a client with some upgrades recently and found this message went away once the app was upgraded to 5.12. Probably can close now? You can see that...

Skip checking the source for synthetic attributes to prevent warning.

@navels thanks, will do

Unable to override serializeQueryParam within route

@denzo @ming-codes Was asking about this myself this morning. Per @rwjblue on Slack, this may not be public but it's at least "intimate API" (i.e. can't be broken). So probably...

Unable to override serializeQueryParam within route

@pixelhandler given the fact that `serializeQueryParam` is listed in Ed's PR tracking public API here (https://github.com/emberjs/ember.js/pull/16910/files#diff-d6b0c0d618513a72b8aec4c128e8b345R471), I think it remains an open question whether we're supporting this or not. As...

Update documentation and localization for 2.4.6

Does this still need to be done or should this issue be closed?

[Chore] Track v2 Breaking Changes

Per notes at https://github.com/JamesLMilner/terra-draw/issues/683, `ignoreMismatchedPointerEvents: true` should probably be a default in v2 as well