Antoine Colombier

Results 485 comments of Antoine Colombier

@daschuer I am also using Qt 6.2 - it turns out that something was broken on QML. The control should now work correctly. Also turned out that I had applied...

I guess it depends. In the one hand, I guess we could always allocate memory assuming that maximum number of supported channel, but in the other hand, it feels like...

> Yes, you are probably right. Than let's stick with the dynamic allocation. This is beneficial if we think to 64 Sampler skins. I finally decided to go with a...

@daschuer I have updated the vectorization info using a small script and caught some other incorrect in [905bce1588](https://github.com/acolombier/mixxx/commit/905bce1588). With your approval, I would like to keep the refactoring of samples...

FYI, next PR in order would be the analyzer support in #13106

> I wonder which options the user needs for multithreading with stems. I guess stem support without any multithreading is not of much practical use. But should we offer proccessing...

> That is not a question IMHO, because mono Rubberband destroys the stereo effect and makes no compatibility. Isn't it a problem we accepted to go with anyway in #13143...

I have added the multi threaded rubberband logic: - If `Multi threaded` is off, stereo channel will be treated together - If on, stereo and stem decks will be treated...

I assume you would like to see the deck computing in parallel, right? I'm afraid that won't only require a refactor of the RubberBand, but rather a refactor of the...

Note that this is only a PoC, and production ready solution could include to make a global pool of thread, instead of owned thread per channel (meaning a max of...