Antoine Colombier

Results 485 comments of Antoine Colombier

Note that, as faired, I have noticed a performance impact on probing the STEM box in each MP4 file, especially when running the tests. This is slightly worrying as I...

Hard to say - I suspect something is wrong in the way the file type is being detected, leading to the `SoundSourceProxy` test to timeout. I will do further investigation,...

After running the `SoundSourceProxyTest` through callgrind, it looks like the probing of the stem atom was too greedy and could stop recursion early on. There is still a slight performance...

@daschuer friendly ping in case you missed the notification

I have made the naming change as suggested. Would you suggest I completely remove the term `runtime` in the Engine API?

> would be a consistent and self explaining naming. Do you agree? Yep sounds good, will update accordingly. > I think I remember reading somewhere (couldn't find the source right...

@Swiftb0y I agree with everything you said, and join you on the fact that a larger work should be planned to enable a better integration with multi-device setup (whether these...

> Did you saw my comment above, that the `__win32__` to `__WINDOWS__`fix got lost in a later push? No I didn't. I don't see where there is Windows-specifc code on...

What is the consensus on required API change to get this feature over the line?

Declaring mapping in the same XML appears to be be a massive amount of work (AFAIK, that's what `ControllerScriptModuleEngine` was aiming for, which is been work in progress for 4...