Michael Ackley comments

Results 39 comments of


                                            Michael Ackley

Move sqlstore and mongostore to separate repos

This is definitely something we could do, I guess the 2 hang ups I have are - Does this split cause an unintuitive deviation from the official Quickfix implementations in...

Move sqlstore and mongostore to separate repos

Sure, I think the decisions in those repos do have some bearing on what we could or should do in this one, regardless of some flexibility we are afforded in...

Move sqlstore and mongostore to separate repos

@Neal resolved in https://github.com/quickfixgo/quickfix/releases/tag/v0.9.0

Fix Send(Messagable) which does not account for TargetSubID & SenderSubID

@sylr If you added a test or two here to ensure accessing these fields in the header doesn't cause any issues here if they don't exist, I will merge it...

Example of user / password login?

> Git history suggests there used to be Can you point me to the relevant history? I can't seem to find it

how to controls filtering of heartbeats for message logging (both in and out)

Please submit a PR with this feature if you end up implementing it, I would like it

MSSQL script: Wrong data type for creation_time

I think I understand the problem, and I think the only repo that might have a solution for us to follow here would be quickfix-j. I think changing the datatype...

Manage dynamic sessions the same as common sessions for acceptor

@haoyang1994 I think our test coverage for dynamic sessions is spotty/nonexistent, so I am hesitant to remove all the dynamic sessions handling logic without at least some new tests for...

feat(testing): New testing feature to enable running both a acceptor and initiator in the same process.

This has backwards compatibility, correct? Quite a lot of changes in here, but it certainly has a lot of benefits