quickfix icon indicating copy to clipboard operation
quickfix copied to clipboard

Manage dynamic sessions the same as common sessions for acceptor

Open haoyang1994 opened this issue 1 year ago • 2 comments

In the current implementation, DynamicSession is unregistered when the connection is disconnected.

Since DynamicSession is unregistered, ErrUnknownSession will appear when the dynamic session is disconnected and the SendToTarget method is called.

DynamicSessions could be managed same as common sessions.

haoyang1994 avatar Aug 08 '24 07:08 haoyang1994

@haoyang1994 I think our test coverage for dynamic sessions is spotty/nonexistent, so I am hesitant to remove all the dynamic sessions handling logic without at least some new tests for them, see if you can add some scenarios to accepter_test.go

ackleymi avatar Aug 09 '24 00:08 ackleymi

Hi @ackleymi , could you help to review the PR #662 ? I think the implementation in #662 is easier to understand and more user-friendly. If you agree with this perspective, I will close the current pull request.

haoyang1994 avatar Aug 15 '24 09:08 haoyang1994