Alex Chubaty

Results 28 comments of Alex Chubaty

indeed, that looks like a very simple and correct fix to the problem you describe. are you able to create a pull request?

Based on CRAN, the directory structure of the archive should look like `/src/contrib/Archive/pkgName/pkgName_x.y.z.tar.gz`. So each package gets a subdirectory for itself in `Archive`, and within a package subdir exists the...

Thanks for that @stefanoborini. I'll also add that the CRAN servers appear to be using `Archive` as a symlink(?) to `00Archive`: ![image](https://user-images.githubusercontent.com/3435577/71012666-b0268680-20ac-11ea-8183-ab55ea3ba930.png)

It makes sense to grab the metadata file to avoid recursing the contents of the directories to find packages. So that will be an additional detail to consider. Yes, 00Archive...

@andrie I can't see comments either. If you began commenting using the review functionality, you may not have clicked "submit review". ![image](https://user-images.githubusercontent.com/3435577/60677172-f8732480-9e3d-11e9-97eb-788cda6ecc02.png)

This probably duplicates #56. The issue is that dependencies may have changed (new dependency packages) and/or dependency versions may have changed, so I think downloading all dependencies is probably the...

You're correct that it currently doesn't address this issue. We hadn't yet taken the time to work through a solution. Presumably, package dependencies that are no longer required should be...

see `devtools::install_remote()` to see how the package source bundle is downloaded. from there, #23's `addLocalPackage` can take over

@msteijaert thank you for taking a first crack at this. I've implemented a version of your function on the `50-addPackageGitHub` branch, though it needs work. See the commit message there....

@paulponcet the function you are proposing should be vectorized to handle multiple package types, the way `addPackage` does (using an `lapply` internally for type).