Alex Potsides

Results 223 issues of Alex Potsides

This is a follow-on to #215, I think the problem still exists, even after `[email protected]`. These references can keep threads alive: ``` # ThreadSafeCallback callback node:internal/async_hooks:202 file:///Users/alex/Documents/Workspaces/libp2p/js-libp2p/node_modules/node-datachannel/polyfill/RTCPeerConnection.js:63 file:///Users/alex/Documents/Workspaces/libp2p/js-libp2p/packages/transport-webrtc/dist/test/peer.spec.js:40 file:///Users/alex/Documents/Workspaces/libp2p/js-libp2p/packages/transport-webrtc/dist/test/peer.spec.js:62 #...

I'm seeing this error on Electron in GitHub actions: ``` /home/runner/.cache/electron/416b9e4fe8fa4ae9903a8176cd1cba59f4b1273f87bab9aaf5ca425d2b7602fc/electron: symbol lookup error: /home/runner/work/js-libp2p/js-libp2p/node_modules/node-datachannel/build/Release/node_datachannel.node: undefined symbol: EVP_MAC_fetch ``` Weirdly I can't replicate it locally on Linux or Mac OS...

The `randombytes` package depends on `safe-buffer` which uses the built-in `buffer` module from node core without declaring the polyfill as a dep. If you have this installed accidentally as a...

When running a test file like [this one](https://github.com/ipfs/js-ipfs-bitswap/blob/master/test/browser.ts) autodetect fails to detect mocha. I think this is because autodetect doesn't load the imported test files to continue trying to detect...

CI logging output can be really hard to read: ``` \x1B[0m\x1B[0m\n' \x1B[0m ping test\x1B[0m\n' \x1B[36m - should listen for ping\x1B[0m\n' ``` Some CI logging setups handle this well, some do...

enhancement

Update to the latest electron version.

This is to support the `"types"` field in `package.json` to support modules that no longer have a root `"types"` field. BREAKING CHANGE: Node16 module resolution ignores "types" and "typesVersions" in...

This has been improved in node v18.18.2 but it's still causing larger/longer builds to hang.

In CI we always build after an install, which happens before testing so we can skip the build step since all build output should have been cached.

The newer repos with auto-generated docs tend to add a `@packageDocumentation` block to the index.ts file with a brief overview of the module. It would be great to automatically add...