Amaury Chamayou

Results 93 issues of Amaury Chamayou

`$Fabric_NodeIPOrFQDN:2377` should be accessible in the pool we use now.

Observed in https://dev.azure.com/MSRC-CCF/CCF/_build/results?buildId=75971&view=logs&j=8f3dc89c-3708-5926-47e7-27120a268dab&t=bb1a7e6d-8f5b-56e4-638c-b498b20b4b62 > /__w/1/s/build/workspace/reconfiguration_reconfiguration_test_cft_12/out:207: 2023-09-19T01:48:39.252933Z 0 [fail ] ../src/enclave/main.cpp:295 | exception during enclave init: could not generate new EC key https://github.com/microsoft/CCF/blob/93de138399d4f4a9eb1f809e187ff1047c26d839/src/crypto/openssl/key_pair.cpp#L59 We should at least log the failure code,...

bug

- [x] Parts of the doc (verify_tx) still use the old enum serialisation format, they need to be updated - [x] The ccf app template repo needs to be upgraded...

bug

Some users may want to have the proposalId when resolving, because their logic depends on distinguishing "other pending proposals" and applying rules to that. This should be a backwards compatible...

enhancement

This is currently logged: Exception in virtual void aft::Aft::recv_message(const ccf::NodeId &, const uint8_t *, size_t) [LedgerProxy = consensus::LedgerEnclave] But the payload is encrypted, and so is safe to log while...

usability

See https://github.com/microsoft/scitt-ccf-ledger/issues/53 and https://github.com/microsoft/scitt-ccf-ledger/issues/88 for history. This information is exposed now in the JSON & C++ receipts as "service_endorsements": https://github.com/microsoft/CCF/blob/b78c1d00133d3c2979d8f11ec10c34345e6bb3b4/include/ccf/receipt.h#L30, but not in a did/jwk-friendly format. This is partially implemented...

enhancement

CCF's KV schema and internal logic assumes JWK kids uses for JWT authentication are unique globally, not per issuer. This is an incorrect assumption, as per https://www.rfc-editor.org/rfc/rfc7517#page-8

bug

Transactions executed while the snapshot is being deserialised may see an inconsistent view of the KV (state not in sync with version, or version not in sync with history). The...