Amaury Chamayou

Results 254 comments of Amaury Chamayou

The output is large (~20klines diff), and some of the includes are questionable, although this is perhaps a matter of using the right options: ``` ../samples/apps/nobuiltins/nobuiltins.cpp should add these lines:...

This isn't CCF specific, let's ask the ACI team if this is something they can provide.

@divneil-intel sandbox takes an interface, which it then binds to. Taking a mask and binding to every IP it includes would be very surprising to most users, and unlikely to...

Re-phrasing this to: is there a lightweight, production-enabled version of the load monitor, which would only log?

> This is shorter, required fewer changes to add s, and includes the behaviour that s will always be written, even if it's still the default, we just permit it...

@lemmy it is the same macros, but it shouldn't impact trace validation.

@eddyashton if this is resolved, we need to remove https://github.com/microsoft/CCF/blob/5b1c504cdbdd12850a3272dd2e13a64a5026f555/tests/infra/network.py#L153, but my reading of #5160 suggests to me that it's not.

The basicperf test does that now when `--stop-primary-after-s --add-new-node-after-primary-stops` is specified.

@DomAyre the bulk of this issue is complete, can you close it and roll the remaining CRL/collateral fetching items into a freshly named 4.x ticket please?