Chris Adams

Results 315 comments of Chris Adams

@shibz Great idea: I'm pretty sure several of the more difficult customizations are completely moot now that we're only supporting Django 1.3+.

@Hedde Did @shibz's patch work for you? I'm getting ready to start testing it on my own projects & definitely like the appeal of such a big boilerplate code removal.

This is probably unrelated - I'll see if I can reproduce it without that patch but I know that part of the Django admin code is fragile. There was at...

For completeness, https://github.com/toastdriven/django-haystack/pull/888#issuecomment-32607737 has a possibly better way to build this

I did it again and left a long comment on the wrong ticket: https://github.com/toastdriven/django-haystack/pull/888#issuecomment-32613309 The basic proposal there would be changing `run()` as above to add the new methods, refactoring...

@toastdriven @HonzaKral As of the commits above, the tests pass locally – I'm looking into Travis now – and the results seem like a nice little cleanup. Any thoughts /...

Rebased against master after #888

We should get this rebased against master, too

This looks good to me — do you have a test which would prevent future regression?