Chris Adams

Results 315 comments of Chris Adams

If anyone else hits this, I side-stepped the issue on an old project by editing `.terraform/modules/gce-lb-http/variables.tf` to change the backend to `type=any` long enough to upgrade to Terraform 0.13, running...

This is basically an area where we need to paper over the underlying implementation differences. The score is a calculated field rather than one which actually exists on the index:...

@cgreene Agreed – there's clearly a need.

Can you explain the circumstances where you get a negative number of results? Ideally this would have a test-case, too.

The PR still could use some tests

Is this completely functionality-neutral? It looks like the tests are passing but I don't know whether you'd like to review coverage on that.

Please add a test case which fails currently and demonstrates that the problem is in haystack and not rpyc.

Hmmm, yes, I'm really not sure why we'd want to have any undefined value return None on a `SearchResult` and the code doesn't make that much clearer: https://github.com/django-haystack/django-haystack/blame/master/haystack/models.py#L64-L68 I'm thinking...

This is still a work in progress but leads to a number of areas for cleaning up old code

This looks good to me. I'm thinking we should have a test which at least uses mock to confirm that the boost is working or at least that the value...