Alex Cabal comments

Results 91 comments of


                                            Alex Cabal

Prefixing the identifier with `url:` is not recommended

Good idea but this will be a lot of work. Not only does the corpus and toolset need to be updated, but the website code as well. Everything will have...

Prefixing the identifier with `url:` is not recommended

That's fine, I can script the corpus.

Prefixing the identifier with `url:` is not recommended

I need to find time to do this. It will take a while.

Don't prefix identifier with `url:`

The tests are failing however, see the checks section at the bottom of this PR.

Don't prefix identifier with `url:`

@brendanny I'm ready to merge this in but there have been changes since this PR, and now there are merge conflicts. Can you fix these so I can merge this...

Don't prefix identifier with `url:`

The one in `tests/build/...`

Don't prefix identifier with `url:`

I think you must have fixed a merge conflict incorrectly somewhere, because the tests in head are working fine. You can install pytest on your local machine to run them...

Don't prefix identifier with `url:`

I suggest just copying the tests from master and pasting them into your PR. Tests are passing in master.

Don't prefix identifier with `url:`

Great work, thanks!

comment about `[Editorial]`

Yes, you can fix those as you suggest. Fixing two characters and writing two brief commit messages is not hard, you could have done that and opened a PR in...