Alex Cabal

Results 91 comments of Alex Cabal

Good idea, thanks! However a word joiner is not necessary because a figure dash only breaks after and not before. Can you remove the word joiner from the changes?

I need to see an example to visualize what's going on. If anything, the first regex should be merged into the xpath, and the xpath updated to exclude the subset...

OK so you can just remove the subsetting then. As far as the structure of the test goes, if it works then I'm not too concerned about the internals. If...

If it works it works. If not, feel free to make any tweaks that might resolve the issue.

Hi folks, I'm not quite sure what this Github issue is referring to specifically since I'm not part of this group; but since Jay asked I'll give a brief rundown...

I understand the reasoning for this PR, but I think regex is acceptable for this use case 95% of the time. It's much simpler to understand and - importantly -...

I understand. We do not *need* lookaheads in the general case (or, strictly speaking, in this case). That is because the occasions in which the regexes without lookaheads are wrong,...

Again, this is an issue with the renderer used by Kobo. When you open a regular epub, you trigger the ADE renderer which is very limited. When you open a...

It does that because Kobo doesn't render no-break hyphens. See https://github.com/standardebooks/tools/blob/9b647cf70fd7c7416c9cdbfd79775947779e9b78/se/se_epub_build.py#L774 Maybe Kobo has fixed that since we added that compatibility tweak?