Eldar Abusalimov
Eldar Abusalimov
@chekunkov Looks good at the first glance, thank you!
Thank you for such a detailed report! I can't tell for sure what the actual reason is, but I suspect that the following steps could lead to the error in...
> I was under impression, that pytest-catchlog would attach only in tests, which use caplog fixture, but it seems it's not the case. Yes, it needs a handler for every...
@alexrudy, thank you for reporting this! If I understand correctly, the error should gone, if you move thread joining logic inside the `with catching_logs(...)` block: ``` python handler = pytest_catchlog.plugin.LogCaptureHandler()...
I think we could add a check to ensure the stream is still alive. Effectively, this would make errors be swallowed silently. I don't like that kind of approach, but...
I think it's also worth removing the `closing(...)` context from the `catching_logs(...)` to let a caller do that explicitly.
Sound good! I wish I had more spare time time to investigate that...
@TBeijen Thanks for submitting this and happy New Year! :christmas_tree: I like the idea in general, and I though about adding somewhat similar too. And if we finally agree on...
@TBeijen ~~Please notice my comments above/~~ Sorry, they have been left pending for all these months. =\
> It seems this breaks using `LogRecord.message` Interesting enough. `LogRecord.message` is initialized by `Formatter.format()`, i.e. lazily. It is probably broken since replacing `StreamHandler` with simple `RecordingHandler`, which doesn't use formatting...