Bruno Oliveira da Silva

Results 99 comments of Bruno Oliveira da Silva

@jonkoops the only work necessary for now is related to review PRs with typescript definitions. If that's ok, next year I will request your team's input on some of them.

@Fydon if you would like to contribute and update the typescript definitions, you are more than welcome. We should now have reviewers for this.

@VarunPeddina indeed the Node.js adapter should support more algorithms. The changes look good, although the PR needs integration tests, otherwise we can't move forward with these changes.

@stianst tests are still missing, would you like to merge those changes without tests?

@stianst updated with Eric's suggestion. Indeed ReDoc should be the way to go.

@ckwalsh thanks for submitting this. The issue reported seems very close to https://issues.redhat.com/browse/KEYCLOAK-12771, which was merged to master. Could you please rebase?

@Spittal once @ckwalsh push the changes to this PR. We can do another round of review.

@stianst I completely missed this change, but considering that it was approved long time ago, I would like to double check if we still would like to merge it. @vmuzikar...

@slaskawi would be possible to add how we plan to protect those endpoints? I can think about mTLS, but it would be nice to make it clear into the document....

@brentlintner go ahead my friend, I think you're more familiar with ripple than me. Glad to help.