Bodor Laszlo

Results 95 comments of Bodor Laszlo

> We are explicitily adding MASK_TOTAL_SIZE in every file, can we have it enabled always > > ``` > public static final String HDFS_MASK = "### HDFS PATH ###"; >...

we're supposed to eliminate the one-by-one masking directives and handle this from the QOutProcessor, so this is supposed to return empty right? ``` grep -iRH "qt:replace.*totalSize" --include="*.q" iceberg/iceberg-handler/src/test/queries/positive/row_count.q:--! qt:replace:/(\s+totalSize\s+)\S+(\s*)/$1#Masked#/ ql/src/test/queries/clientpositive/compaction_query_based_insert_only_clustered.q:--!...

> @abstractdog, could this be merged or some comments are still pending? there are minor comments unaddressed

@ayushtkn : can you please rebase this patch on top of master? LGTM, let's just have a fresh test run

> @abstractdog @harishjp. Can you please help get this in tez 0.10.3 thanks @Aggarwal-Raghav for the patch, let me check soon I'm really sorry but tez 0.10.3 rc1 is currently...

CodedInputStream.totalBytesRetired can be easily checked by CodedInputStream.getTotalBytesRead(), so can you include a unit test that reads at least twice with ProtoMessageWritable and validates that cin.resetSizeCounter() was indeed called?

@Aggarwal-Raghav : can you fix this minor checkstyle warning? https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-334/3/artifact/out/diff-checkstyle-tez-plugins_tez-protobuf-history-plugin.txt + 1 more minor comment other than that this LGTM

left minor comments on this @VenkatSNarayanan , other than that, this looks good to me

one more thing @VenkatSNarayanan , please address checkstyle comments where applicable, thanks!