tez icon indicating copy to clipboard operation
tez copied to clipboard

TEZ-4547: Add Tez AM JobID to the JobConf

Open VenkatSNarayanan opened this issue 11 months ago • 14 comments

Some committers require a job-wide UUID to function correctly. Adding the AM JobID to the JobConf will allow applications to pass that to the committers that need it.

VenkatSNarayanan avatar Mar 13 '24 18:03 VenkatSNarayanan

:broken_heart: -1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 26m 49s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
-1 :x: test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 :green_heart: mvninstall 31m 10s master passed
+1 :green_heart: compile 0m 38s master passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1
+1 :green_heart: compile 0m 33s master passed with JDK Private Build-1.8.0_392-8u392-ga-1~22.04-b08
+1 :green_heart: checkstyle 1m 38s master passed
+1 :green_heart: javadoc 0m 48s master passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1
+1 :green_heart: javadoc 0m 30s master passed with JDK Private Build-1.8.0_392-8u392-ga-1~22.04-b08
+0 :ok: spotbugs 1m 45s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 :green_heart: findbugs 1m 43s master passed
_ Patch Compile Tests _
+1 :green_heart: mvninstall 0m 24s the patch passed
+1 :green_heart: compile 0m 27s the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1
+1 :green_heart: javac 0m 27s the patch passed
+1 :green_heart: compile 0m 22s the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~22.04-b08
+1 :green_heart: javac 0m 22s the patch passed
-0 :warning: checkstyle 0m 20s tez-mapreduce: The patch generated 3 new + 349 unchanged - 0 fixed = 352 total (was 349)
+1 :green_heart: whitespace 0m 0s The patch has no whitespace issues.
+1 :green_heart: javadoc 0m 20s the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1
+1 :green_heart: javadoc 0m 18s the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~22.04-b08
+1 :green_heart: findbugs 1m 0s the patch passed
_ Other Tests _
+1 :green_heart: unit 1m 38s tez-mapreduce in the patch passed.
+1 :green_heart: asflicense 0m 18s The patch does not generate ASF License warnings.
70m 3s
Subsystem Report/Notes
Docker ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-339/1/artifact/out/Dockerfile
GITHUB PR https://github.com/apache/tez/pull/339
JIRA Issue TEZ-4547
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile
uname Linux 07d7e29a04db 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/tez.sh
git revision master / 34bb628e3
Default Java Private Build-1.8.0_392-8u392-ga-1~22.04-b08
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~22.04-b08
checkstyle https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-339/1/artifact/out/diff-checkstyle-tez-mapreduce.txt
Test Results https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-339/1/testReport/
Max. process+thread count 231 (vs. ulimit of 5500)
modules C: tez-mapreduce U: tez-mapreduce
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-339/1/console
versions git=2.34.1 maven=3.6.3 findbugs=3.0.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

tez-yetus avatar Mar 13 '24 19:03 tez-yetus

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 34s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ master Compile Tests _
+1 :green_heart: mvninstall 28m 11s master passed
+1 :green_heart: compile 0m 37s master passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1
+1 :green_heart: compile 0m 34s master passed with JDK Private Build-1.8.0_392-8u392-ga-1~22.04-b08
+1 :green_heart: checkstyle 1m 38s master passed
+1 :green_heart: javadoc 0m 48s master passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1
+1 :green_heart: javadoc 0m 29s master passed with JDK Private Build-1.8.0_392-8u392-ga-1~22.04-b08
+0 :ok: spotbugs 1m 46s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 :green_heart: findbugs 1m 43s master passed
_ Patch Compile Tests _
+1 :green_heart: mvninstall 0m 23s the patch passed
+1 :green_heart: compile 0m 27s the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1
+1 :green_heart: javac 0m 27s the patch passed
+1 :green_heart: compile 0m 22s the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~22.04-b08
+1 :green_heart: javac 0m 22s the patch passed
-0 :warning: checkstyle 0m 20s tez-mapreduce: The patch generated 7 new + 368 unchanged - 0 fixed = 375 total (was 368)
+1 :green_heart: whitespace 0m 0s The patch has no whitespace issues.
+1 :green_heart: javadoc 0m 20s the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1
+1 :green_heart: javadoc 0m 18s the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~22.04-b08
+1 :green_heart: findbugs 1m 0s the patch passed
_ Other Tests _
+1 :green_heart: unit 1m 40s tez-mapreduce in the patch passed.
+1 :green_heart: asflicense 0m 18s The patch does not generate ASF License warnings.
40m 49s
Subsystem Report/Notes
Docker ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-339/2/artifact/out/Dockerfile
GITHUB PR https://github.com/apache/tez/pull/339
JIRA Issue TEZ-4547
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile
uname Linux 67ed1b8bb238 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/tez.sh
git revision master / 34bb628e3
Default Java Private Build-1.8.0_392-8u392-ga-1~22.04-b08
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~22.04-b08
checkstyle https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-339/2/artifact/out/diff-checkstyle-tez-mapreduce.txt
Test Results https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-339/2/testReport/
Max. process+thread count 227 (vs. ulimit of 5500)
modules C: tez-mapreduce U: tez-mapreduce
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-339/2/console
versions git=2.34.1 maven=3.6.3 findbugs=3.0.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

tez-yetus avatar Mar 13 '24 19:03 tez-yetus

If my understanding is correct, Hive/Pig would use the value from mapreduce.parent.job.id to set the correct committer UUID right?

Yes, that was the plan. The property name was just chosen arbitrarily so I could put the PR up, any suggestions for a better one are welcome.

VenkatSNarayanan avatar Mar 18 '24 18:03 VenkatSNarayanan

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 28m 32s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ master Compile Tests _
+0 :ok: mvndep 6m 34s Maven dependency ordering for branch
+1 :green_heart: mvninstall 14m 31s master passed
+1 :green_heart: compile 1m 55s master passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1
+1 :green_heart: compile 1m 43s master passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
+1 :green_heart: checkstyle 2m 9s master passed
+1 :green_heart: javadoc 1m 48s master passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1
+1 :green_heart: javadoc 1m 27s master passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
+0 :ok: spotbugs 1m 23s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 :green_heart: findbugs 3m 55s master passed
_ Patch Compile Tests _
+0 :ok: mvndep 0m 10s Maven dependency ordering for patch
+1 :green_heart: mvninstall 1m 13s the patch passed
+1 :green_heart: compile 1m 20s the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1
+1 :green_heart: javac 1m 20s the patch passed
+1 :green_heart: compile 1m 10s the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
+1 :green_heart: javac 1m 10s the patch passed
-0 :warning: checkstyle 0m 14s tez-api: The patch generated 1 new + 16 unchanged - 0 fixed = 17 total (was 16)
-0 :warning: checkstyle 0m 18s tez-mapreduce: The patch generated 5 new + 368 unchanged - 0 fixed = 373 total (was 368)
+1 :green_heart: whitespace 0m 0s The patch has no whitespace issues.
+1 :green_heart: javadoc 0m 54s the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1
+1 :green_heart: javadoc 0m 54s the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
+1 :green_heart: findbugs 3m 18s the patch passed
_ Other Tests _
+1 :green_heart: unit 2m 23s tez-api in the patch passed.
+1 :green_heart: unit 1m 24s tez-mapreduce in the patch passed.
+1 :green_heart: unit 5m 6s tez-dag in the patch passed.
+1 :green_heart: asflicense 0m 37s The patch does not generate ASF License warnings.
83m 43s
Subsystem Report/Notes
Docker ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-339/3/artifact/out/Dockerfile
GITHUB PR https://github.com/apache/tez/pull/339
JIRA Issue TEZ-4547
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile
uname Linux 6d51356225eb 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/tez.sh
git revision master / 34bb628e3
Default Java Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
checkstyle https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-339/3/artifact/out/diff-checkstyle-tez-api.txt
checkstyle https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-339/3/artifact/out/diff-checkstyle-tez-mapreduce.txt
Test Results https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-339/3/testReport/
Max. process+thread count 507 (vs. ulimit of 5500)
modules C: tez-api tez-mapreduce tez-dag U: .
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-339/3/console
versions git=2.34.1 maven=3.6.3 findbugs=3.0.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

tez-yetus avatar Mar 19 '24 18:03 tez-yetus

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 26m 48s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 1s No case conflicting files found.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ master Compile Tests _
+0 :ok: mvndep 5m 33s Maven dependency ordering for branch
+1 :green_heart: mvninstall 10m 15s master passed
+1 :green_heart: compile 1m 54s master passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1
+1 :green_heart: compile 1m 44s master passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
+1 :green_heart: checkstyle 2m 2s master passed
+1 :green_heart: javadoc 1m 41s master passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1
+1 :green_heart: javadoc 1m 29s master passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
+0 :ok: spotbugs 1m 22s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 :green_heart: findbugs 3m 47s master passed
_ Patch Compile Tests _
+0 :ok: mvndep 0m 10s Maven dependency ordering for patch
+1 :green_heart: mvninstall 1m 9s the patch passed
+1 :green_heart: compile 1m 16s the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1
+1 :green_heart: javac 1m 16s the patch passed
+1 :green_heart: compile 1m 5s the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
+1 :green_heart: javac 1m 5s the patch passed
-0 :warning: checkstyle 0m 13s tez-api: The patch generated 1 new + 16 unchanged - 0 fixed = 17 total (was 16)
-0 :warning: checkstyle 0m 18s tez-mapreduce: The patch generated 4 new + 368 unchanged - 0 fixed = 372 total (was 368)
+1 :green_heart: whitespace 0m 0s The patch has no whitespace issues.
+1 :green_heart: javadoc 0m 51s the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1
+1 :green_heart: javadoc 0m 51s the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
+1 :green_heart: findbugs 3m 4s the patch passed
_ Other Tests _
+1 :green_heart: unit 2m 15s tez-api in the patch passed.
+1 :green_heart: unit 1m 21s tez-mapreduce in the patch passed.
+1 :green_heart: unit 5m 0s tez-dag in the patch passed.
+1 :green_heart: asflicense 0m 33s The patch does not generate ASF License warnings.
75m 27s
Subsystem Report/Notes
Docker ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-339/4/artifact/out/Dockerfile
GITHUB PR https://github.com/apache/tez/pull/339
JIRA Issue TEZ-4547
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile
uname Linux 143e09ab5003 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/tez.sh
git revision master / 34bb628e3
Default Java Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
checkstyle https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-339/4/artifact/out/diff-checkstyle-tez-api.txt
checkstyle https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-339/4/artifact/out/diff-checkstyle-tez-mapreduce.txt
Test Results https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-339/4/testReport/
Max. process+thread count 403 (vs. ulimit of 5500)
modules C: tez-api tez-mapreduce tez-dag U: .
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-339/4/console
versions git=2.34.1 maven=3.6.3 findbugs=3.0.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

tez-yetus avatar Apr 01 '24 19:04 tez-yetus

@shameersss1 We could actually just set fs.s3a.committer.uuid directly instead of the indirection through the other setting.

VenkatSNarayanan avatar Apr 05 '24 05:04 VenkatSNarayanan

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 36s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 1s No case conflicting files found.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ master Compile Tests _
+0 :ok: mvndep 6m 17s Maven dependency ordering for branch
+1 :green_heart: mvninstall 13m 11s master passed
+1 :green_heart: compile 1m 57s master passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1
+1 :green_heart: compile 1m 45s master passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
+1 :green_heart: checkstyle 2m 2s master passed
+1 :green_heart: javadoc 1m 46s master passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1
+1 :green_heart: javadoc 1m 30s master passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
+0 :ok: spotbugs 1m 21s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 :green_heart: findbugs 3m 44s master passed
_ Patch Compile Tests _
+0 :ok: mvndep 0m 10s Maven dependency ordering for patch
+1 :green_heart: mvninstall 1m 9s the patch passed
+1 :green_heart: compile 1m 16s the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1
+1 :green_heart: javac 1m 16s the patch passed
+1 :green_heart: compile 1m 5s the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
+1 :green_heart: javac 1m 5s the patch passed
-0 :warning: checkstyle 0m 12s tez-api: The patch generated 1 new + 16 unchanged - 0 fixed = 17 total (was 16)
-0 :warning: checkstyle 0m 18s tez-mapreduce: The patch generated 4 new + 368 unchanged - 0 fixed = 372 total (was 368)
+1 :green_heart: whitespace 0m 0s The patch has no whitespace issues.
+1 :green_heart: javadoc 0m 51s the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1
+1 :green_heart: javadoc 0m 51s the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
+1 :green_heart: findbugs 3m 3s the patch passed
_ Other Tests _
+1 :green_heart: unit 2m 16s tez-api in the patch passed.
+1 :green_heart: unit 1m 23s tez-mapreduce in the patch passed.
+1 :green_heart: unit 5m 0s tez-dag in the patch passed.
+1 :green_heart: asflicense 0m 32s The patch does not generate ASF License warnings.
53m 6s
Subsystem Report/Notes
Docker ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-339/5/artifact/out/Dockerfile
GITHUB PR https://github.com/apache/tez/pull/339
JIRA Issue TEZ-4547
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile
uname Linux 7c897a5b673b 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/tez.sh
git revision master / f080031f5
Default Java Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
checkstyle https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-339/5/artifact/out/diff-checkstyle-tez-api.txt
checkstyle https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-339/5/artifact/out/diff-checkstyle-tez-mapreduce.txt
Test Results https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-339/5/testReport/
Max. process+thread count 372 (vs. ulimit of 5500)
modules C: tez-api tez-mapreduce tez-dag U: .
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-339/5/console
versions git=2.34.1 maven=3.6.3 findbugs=3.0.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

tez-yetus avatar Apr 05 '24 07:04 tez-yetus

@abstractdog - Could you please review the same ?

shameersss1 avatar Apr 05 '24 07:04 shameersss1

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 26m 4s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ master Compile Tests _
+0 :ok: mvndep 6m 25s Maven dependency ordering for branch
+1 :green_heart: mvninstall 12m 58s master passed
+1 :green_heart: compile 1m 54s master passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1
+1 :green_heart: compile 1m 46s master passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
+1 :green_heart: checkstyle 2m 8s master passed
+1 :green_heart: javadoc 1m 44s master passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1
+1 :green_heart: javadoc 1m 29s master passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
+0 :ok: spotbugs 1m 20s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 :green_heart: findbugs 3m 50s master passed
_ Patch Compile Tests _
+0 :ok: mvndep 0m 11s Maven dependency ordering for patch
+1 :green_heart: mvninstall 1m 9s the patch passed
+1 :green_heart: compile 1m 18s the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1
+1 :green_heart: javac 1m 18s the patch passed
+1 :green_heart: compile 1m 5s the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
+1 :green_heart: javac 1m 5s the patch passed
-0 :warning: checkstyle 0m 12s tez-api: The patch generated 1 new + 16 unchanged - 0 fixed = 17 total (was 16)
-0 :warning: checkstyle 0m 18s tez-mapreduce: The patch generated 2 new + 368 unchanged - 0 fixed = 370 total (was 368)
+1 :green_heart: whitespace 0m 0s The patch has no whitespace issues.
+1 :green_heart: javadoc 0m 53s the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1
+1 :green_heart: javadoc 0m 51s the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
+1 :green_heart: findbugs 3m 5s the patch passed
_ Other Tests _
+1 :green_heart: unit 2m 18s tez-api in the patch passed.
+1 :green_heart: unit 1m 23s tez-mapreduce in the patch passed.
+1 :green_heart: unit 4m 58s tez-dag in the patch passed.
+1 :green_heart: asflicense 0m 33s The patch does not generate ASF License warnings.
78m 42s
Subsystem Report/Notes
Docker ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-339/6/artifact/out/Dockerfile
GITHUB PR https://github.com/apache/tez/pull/339
JIRA Issue TEZ-4547
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile
uname Linux efb9ed2193d6 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/tez.sh
git revision master / f080031f5
Default Java Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
checkstyle https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-339/6/artifact/out/diff-checkstyle-tez-api.txt
checkstyle https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-339/6/artifact/out/diff-checkstyle-tez-mapreduce.txt
Test Results https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-339/6/testReport/
Max. process+thread count 492 (vs. ulimit of 5500)
modules C: tez-api tez-mapreduce tez-dag U: .
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-339/6/console
versions git=2.34.1 maven=3.6.3 findbugs=3.0.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

tez-yetus avatar Apr 08 '24 20:04 tez-yetus

@abstractdog @shameersss1 Is there anything else needed?

VenkatSNarayanan avatar May 07 '24 20:05 VenkatSNarayanan

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 27m 44s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ master Compile Tests _
+0 :ok: mvndep 5m 31s Maven dependency ordering for branch
+1 :green_heart: mvninstall 10m 37s master passed
+1 :green_heart: compile 1m 55s master passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1
+1 :green_heart: compile 1m 44s master passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
+1 :green_heart: checkstyle 1m 59s master passed
+1 :green_heart: javadoc 1m 43s master passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1
+1 :green_heart: javadoc 1m 31s master passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
+0 :ok: spotbugs 1m 20s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 :green_heart: findbugs 3m 46s master passed
_ Patch Compile Tests _
+0 :ok: mvndep 0m 10s Maven dependency ordering for patch
+1 :green_heart: mvninstall 1m 9s the patch passed
+1 :green_heart: compile 1m 17s the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1
+1 :green_heart: javac 1m 17s the patch passed
+1 :green_heart: compile 1m 6s the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
+1 :green_heart: javac 1m 6s the patch passed
-0 :warning: checkstyle 0m 12s tez-api: The patch generated 1 new + 16 unchanged - 0 fixed = 17 total (was 16)
-0 :warning: checkstyle 0m 18s tez-mapreduce: The patch generated 2 new + 368 unchanged - 0 fixed = 370 total (was 368)
-0 :warning: checkstyle 0m 27s tez-dag: The patch generated 1 new + 281 unchanged - 0 fixed = 282 total (was 281)
+1 :green_heart: whitespace 0m 0s The patch has no whitespace issues.
+1 :green_heart: javadoc 0m 53s the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1
+1 :green_heart: javadoc 0m 53s the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
+1 :green_heart: findbugs 3m 3s the patch passed
_ Other Tests _
+1 :green_heart: unit 2m 15s tez-api in the patch passed.
+1 :green_heart: unit 1m 24s tez-mapreduce in the patch passed.
+1 :green_heart: unit 5m 2s tez-dag in the patch passed.
+1 :green_heart: asflicense 0m 32s The patch does not generate ASF License warnings.
76m 54s
Subsystem Report/Notes
Docker ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-339/7/artifact/out/Dockerfile
GITHUB PR https://github.com/apache/tez/pull/339
JIRA Issue TEZ-4547
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile
uname Linux 72ee90ea8cae 5.15.0-106-generic #116-Ubuntu SMP Wed Apr 17 09:17:56 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/tez.sh
git revision master / 38c5aaccd
Default Java Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
checkstyle https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-339/7/artifact/out/diff-checkstyle-tez-api.txt
checkstyle https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-339/7/artifact/out/diff-checkstyle-tez-mapreduce.txt
checkstyle https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-339/7/artifact/out/diff-checkstyle-tez-dag.txt
Test Results https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-339/7/testReport/
Max. process+thread count 410 (vs. ulimit of 5500)
modules C: tez-api tez-mapreduce tez-dag U: .
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-339/7/console
versions git=2.34.1 maven=3.6.3 findbugs=3.0.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

tez-yetus avatar May 28 '24 20:05 tez-yetus

left minor comments on this @VenkatSNarayanan , other than that, this looks good to me

abstractdog avatar Jun 20 '24 07:06 abstractdog

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 25m 52s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 1s No case conflicting files found.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ master Compile Tests _
+0 :ok: mvndep 6m 14s Maven dependency ordering for branch
+1 :green_heart: mvninstall 12m 57s master passed
+1 :green_heart: compile 1m 56s master passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu122.04.1
+1 :green_heart: compile 1m 44s master passed with JDK Private Build-1.8.0_412-8u412-ga-1~22.04.1-b08
+1 :green_heart: checkstyle 1m 58s master passed
+1 :green_heart: javadoc 1m 44s master passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu122.04.1
+1 :green_heart: javadoc 1m 29s master passed with JDK Private Build-1.8.0_412-8u412-ga-1~22.04.1-b08
+0 :ok: spotbugs 1m 20s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 :green_heart: findbugs 3m 47s master passed
_ Patch Compile Tests _
+0 :ok: mvndep 0m 10s Maven dependency ordering for patch
+1 :green_heart: mvninstall 1m 9s the patch passed
+1 :green_heart: compile 1m 17s the patch passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu122.04.1
+1 :green_heart: javac 1m 17s the patch passed
+1 :green_heart: compile 1m 7s the patch passed with JDK Private Build-1.8.0_412-8u412-ga-1~22.04.1-b08
+1 :green_heart: javac 1m 7s the patch passed
-0 :warning: checkstyle 0m 13s tez-api: The patch generated 1 new + 16 unchanged - 0 fixed = 17 total (was 16)
-0 :warning: checkstyle 0m 19s tez-mapreduce: The patch generated 3 new + 368 unchanged - 0 fixed = 371 total (was 368)
+1 :green_heart: whitespace 0m 0s The patch has no whitespace issues.
+1 :green_heart: javadoc 0m 52s the patch passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu122.04.1
+1 :green_heart: javadoc 0m 52s the patch passed with JDK Private Build-1.8.0_412-8u412-ga-1~22.04.1-b08
+1 :green_heart: findbugs 3m 5s the patch passed
_ Other Tests _
+1 :green_heart: unit 2m 17s tez-api in the patch passed.
+1 :green_heart: unit 1m 23s tez-mapreduce in the patch passed.
+1 :green_heart: unit 5m 0s tez-dag in the patch passed.
+1 :green_heart: asflicense 0m 34s The patch does not generate ASF License warnings.
78m 8s
Subsystem Report/Notes
Docker ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-339/8/artifact/out/Dockerfile
GITHUB PR https://github.com/apache/tez/pull/339
JIRA Issue TEZ-4547
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile
uname Linux e2f1dda150af 5.15.0-106-generic #116-Ubuntu SMP Wed Apr 17 09:17:56 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/tez.sh
git revision master / 19b2351a9
Default Java Private Build-1.8.0_412-8u412-ga-1~22.04.1-b08
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu122.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_412-8u412-ga-1~22.04.1-b08
checkstyle https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-339/8/artifact/out/diff-checkstyle-tez-api.txt
checkstyle https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-339/8/artifact/out/diff-checkstyle-tez-mapreduce.txt
Test Results https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-339/8/testReport/
Max. process+thread count 423 (vs. ulimit of 5500)
modules C: tez-api tez-mapreduce tez-dag U: .
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-339/8/console
versions git=2.34.1 maven=3.6.3 findbugs=3.0.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

tez-yetus avatar Jun 26 '24 20:06 tez-yetus

one more thing @VenkatSNarayanan , please address checkstyle comments where applicable, thanks!

abstractdog avatar Jun 28 '24 04:06 abstractdog

:broken_heart: -1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 0s Docker mode activated.
-1 :x: docker 0m 20s Docker failed to build yetus/tez:86b11997b.
Subsystem Report/Notes
GITHUB PR https://github.com/apache/tez/pull/339
JIRA Issue TEZ-4547
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-339/9/console
versions git=2.34.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

tez-yetus avatar Jul 10 '24 18:07 tez-yetus

ok. if you look into _SUCCESS json from an s3a or the manifest committer, then the job id is one of the root attributes, as is the source

there's a java definition of this in org.apache.hadoop.mapreduce.lib.output.committer.manifest.files.ManifestSuccessData in recent hadoop-mapreduce binaries

steveloughran avatar Aug 01 '24 10:08 steveloughran

guys: @steveloughran , @VenkatSNarayanan : please let me know if this PR is fine to be merged to tez (from hadoop's point of view)? I'm about to start the release process of 0.10.4 soon latest comment is that no objections, so I'm assuming we're fine with the current name of this config property

abstractdog avatar Aug 02 '24 08:08 abstractdog

guys: @steveloughran , @VenkatSNarayanan : please let me know if this PR is fine to be merged to tez (from hadoop's point of view)? I'm about to start the release process of 0.10.4 soon latest comment is that no objections, so I'm assuming we're fine with the current name of this config property

FYI: I'm about to merge this tomorrow to have this in tez 0.10.4

abstractdog avatar Aug 04 '24 06:08 abstractdog