Bodor Laszlo

Results 95 comments of Bodor Laszlo

the affected lines were touched by @rbalamohan in the past frequently, he is the PipelinedSorter expert, is there a chance you can take a look at this tiny patch?

https://github.com/apache/tez/pull/300#discussion_r1465747416 numerical overflow: does this exactly mean the possible negative values of the arbitrary origin time?

thanks for clarifying @pudidic , implementation looks good to me +1, pending tests

I'm wondering how could weproceed with this, trying to understand TEZ-3302 in practice at the same time @zhangbutao , @rbalamohan : can you explain a scenario when this timeout is...

> Minor Stuff, else looks good thanks a lot, addressed your comments

> At first glance it looks reasonable. I will take a better look tomorrow. > > One thing that I am not sure if it's beneficial is using the `serdeConstants`...

> I think you missed updating the commit message with Hive jira LOL, thanks, fixed

unrelated test failure, I can rerun eventually, this can be reviewed

@zhangbutao : thanks for your comments, according to the last comment, I'm considering this as approved, let me know if it's otherwise