tez icon indicating copy to clipboard operation
tez copied to clipboard

Resolve deadlock in ShuffleScheduler which occurs when ShufflePenalty…

Open glapark opened this issue 3 years ago • 2 comments

…Referee waits for the lock of huffleScheduler.

Fix: do not hold ShuffleScheduler.this when calling exceptionReporter.reportException() remove synchronized in copyFailed()

glapark avatar Sep 03 '21 03:09 glapark

:broken_heart: -1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 16m 18s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+1 :green_heart: @author 0m 1s The patch does not contain any @author tags.
-1 :x: test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 :green_heart: mvninstall 13m 38s master passed
+1 :green_heart: compile 0m 33s master passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 :green_heart: compile 0m 29s master passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 :green_heart: checkstyle 1m 3s master passed
+1 :green_heart: javadoc 0m 39s master passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 :green_heart: javadoc 0m 27s master passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+0 :ok: spotbugs 1m 22s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 :green_heart: findbugs 1m 20s master passed
_ Patch Compile Tests _
+1 :green_heart: mvninstall 0m 21s the patch passed
+1 :green_heart: compile 0m 22s the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 :green_heart: javac 0m 22s the patch passed
+1 :green_heart: compile 0m 19s the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 :green_heart: javac 0m 19s the patch passed
-0 :warning: checkstyle 0m 15s tez-runtime-library: The patch generated 4 new + 35 unchanged - 4 fixed = 39 total (was 39)
+1 :green_heart: whitespace 0m 0s The patch has no whitespace issues.
+1 :green_heart: javadoc 0m 18s the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 :green_heart: javadoc 0m 16s the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 :green_heart: findbugs 0m 54s the patch passed
_ Other Tests _
+1 :green_heart: unit 5m 6s tez-runtime-library in the patch passed.
+1 :green_heart: asflicense 0m 13s The patch does not generate ASF License warnings.
43m 19s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-150/1/artifact/out/Dockerfile
GITHUB PR https://github.com/apache/tez/pull/150
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile
uname Linux a23326c76113 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/tez.sh
git revision master / c875b8216
Default Java Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
checkstyle https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-150/1/artifact/out/diff-checkstyle-tez-runtime-library.txt
Test Results https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-150/1/testReport/
Max. process+thread count 1089 (vs. ulimit of 5500)
modules C: tez-runtime-library U: tez-runtime-library
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-150/1/console
versions git=2.25.1 maven=3.6.3 findbugs=3.0.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

tez-yetus avatar Sep 03 '21 03:09 tez-yetus

:broken_heart: -1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 12m 28s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
-1 :x: test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 :green_heart: mvninstall 12m 44s master passed
+1 :green_heart: compile 0m 35s master passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 :green_heart: compile 0m 32s master passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 :green_heart: checkstyle 1m 8s master passed
+1 :green_heart: javadoc 0m 42s master passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 :green_heart: javadoc 0m 29s master passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+0 :ok: spotbugs 1m 25s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 :green_heart: findbugs 1m 23s master passed
_ Patch Compile Tests _
+1 :green_heart: mvninstall 0m 19s the patch passed
+1 :green_heart: compile 0m 22s the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 :green_heart: javac 0m 22s the patch passed
+1 :green_heart: compile 0m 19s the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 :green_heart: javac 0m 19s the patch passed
-0 :warning: checkstyle 0m 15s tez-runtime-library: The patch generated 4 new + 35 unchanged - 4 fixed = 39 total (was 39)
+1 :green_heart: whitespace 0m 0s The patch has no whitespace issues.
+1 :green_heart: javadoc 0m 18s the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 :green_heart: javadoc 0m 16s the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 :green_heart: findbugs 0m 52s the patch passed
_ Other Tests _
+1 :green_heart: unit 5m 22s tez-runtime-library in the patch passed.
+1 :green_heart: asflicense 0m 14s The patch does not generate ASF License warnings.
39m 12s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-150/2/artifact/out/Dockerfile
GITHUB PR https://github.com/apache/tez/pull/150
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile
uname Linux adc4fcac2a31 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/tez.sh
git revision master / c875b8216
Default Java Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
checkstyle https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-150/2/artifact/out/diff-checkstyle-tez-runtime-library.txt
Test Results https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-150/2/testReport/
Max. process+thread count 2099 (vs. ulimit of 5500)
modules C: tez-runtime-library U: tez-runtime-library
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-150/2/console
versions git=2.25.1 maven=3.6.3 findbugs=3.0.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

tez-yetus avatar Sep 19 '21 12:09 tez-yetus

merged by https://github.com/apache/tez/pull/273

abstractdog avatar Mar 06 '23 15:03 abstractdog