Bodor Laszlo

Results 95 comments of Bodor Laszlo

thanks for this patch @georgekankava, this often generates warnings in code quality tools, it makes sense to take care of those! could you please create a TEZ jira and rebase...

this PR indeed improves code quality, I've left some comments let's consider testing this on a cluster before merging

I just picked this up while creating tez 0.10.2, can you please review @sidseth ?

thanks for the review @prasanthj, I tried to address everything you mentioned

thanks for the patch @Celebrate-future in general, there is a good idea to exclude not used transitive dependencies could you please create a Jira for this PR?

@ghanko : could you please retry this patch to check if the build failures were intermittent or something permanent to check and fix?

my previous comment was addressed, other than that this is mostly a copy from another repo (I mean don't have to read it line-by-line), precommit is green, so it's a...

@darionyaphet, I can see that this patch has been already approved on jira, could you please rebase this PR for the latest test results? this looks good to me, I...

I just found this PR, thanks @georgekankava for the patch! could you please create a TEZ jira ticket this and rebase the patch on latest tez master?

nice catch! credentials are already logged in TezChild constructor by: https://github.com/apache/tez/blob/master/tez-runtime-internals/src/main/java/org/apache/tez/runtime/task/TezChild.java#L203 ``` TezCommonUtils.logCredentials(LOG, credentials, "tezChildInit"); ``` wouldn't this be enough? not 100% in line with hadoop, but adds a useful...