tez icon indicating copy to clipboard operation
tez copied to clipboard

TEZ-4039: Tez should inject dag id, query id into MDC

Open abstractdog opened this issue 4 years ago • 1 comments

abstractdog avatar Feb 01 '21 05:02 abstractdog

thanks for the review @prasanthj, I tried to address everything you mentioned

abstractdog avatar Feb 06 '21 14:02 abstractdog

:broken_heart: -1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 30s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: test4tests 0m 1s The patch appears to include 2 new or modified test files.
_ master Compile Tests _
+0 :ok: mvndep 5m 41s Maven dependency ordering for branch
+1 :green_heart: mvninstall 10m 24s master passed
+1 :green_heart: compile 4m 2s master passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 :green_heart: compile 3m 33s master passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 :green_heart: checkstyle 3m 9s master passed
+1 :green_heart: javadoc 3m 47s master passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 :green_heart: javadoc 3m 16s master passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+0 :ok: spotbugs 0m 59s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 :green_heart: findbugs 5m 56s master passed
_ Patch Compile Tests _
+0 :ok: mvndep 0m 11s Maven dependency ordering for patch
+1 :green_heart: mvninstall 1m 53s the patch passed
+1 :green_heart: compile 2m 0s the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 :green_heart: javac 2m 0s the patch passed
+1 :green_heart: compile 1m 48s the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 :green_heart: javac 1m 48s the patch passed
-0 :warning: checkstyle 0m 11s tez-common: The patch generated 1 new + 56 unchanged - 0 fixed = 57 total (was 56)
+1 :green_heart: whitespace 0m 0s The patch has no whitespace issues.
-1 :x: javadoc 0m 27s tez-api-jdkUbuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 generated 3 new + 13 unchanged - 0 fixed = 16 total (was 13)
+1 :green_heart: javadoc 1m 37s the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 :green_heart: findbugs 4m 29s the patch passed
_ Other Tests _
+1 :green_heart: unit 2m 18s tez-api in the patch passed.
+1 :green_heart: unit 0m 29s tez-common in the patch passed.
+1 :green_heart: unit 0m 41s tez-runtime-internals in the patch passed.
+1 :green_heart: unit 5m 22s tez-dag in the patch passed.
+1 :green_heart: unit 41m 14s tez-tests in the patch passed.
+1 :green_heart: asflicense 1m 10s The patch does not generate ASF License warnings.
108m 37s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-98/5/artifact/out/Dockerfile
GITHUB PR https://github.com/apache/tez/pull/98
JIRA Issue TEZ-4039
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile
uname Linux 53d600d50abc 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/tez.sh
git revision master / 921de531f
Default Java Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
checkstyle https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-98/5/artifact/out/diff-checkstyle-tez-common.txt
javadoc https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-98/5/artifact/out/diff-javadoc-javadoc-tez-api-jdkUbuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04.txt
Test Results https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-98/5/testReport/
Max. process+thread count 1384 (vs. ulimit of 5500)
modules C: tez-api tez-common tez-runtime-internals tez-dag tez-tests U: .
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-98/5/console
versions git=2.25.1 maven=3.6.3 findbugs=3.0.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

tez-yetus avatar Oct 21 '22 10:10 tez-yetus

:broken_heart: -1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 33m 13s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: test4tests 0m 0s The patch appears to include 2 new or modified test files.
_ master Compile Tests _
+0 :ok: mvndep 5m 55s Maven dependency ordering for branch
+1 :green_heart: mvninstall 10m 9s master passed
+1 :green_heart: compile 3m 44s master passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 :green_heart: compile 3m 21s master passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 :green_heart: checkstyle 3m 36s master passed
+1 :green_heart: javadoc 3m 29s master passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 :green_heart: javadoc 3m 15s master passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+0 :ok: spotbugs 0m 56s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 :green_heart: findbugs 6m 3s master passed
_ Patch Compile Tests _
+0 :ok: mvndep 0m 10s Maven dependency ordering for patch
-1 :x: mvninstall 0m 16s tez-runtime-internals in the patch failed.
-1 :x: compile 0m 19s tez-runtime-internals in the patch failed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04.
-1 :x: javac 0m 19s tez-runtime-internals in the patch failed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04.
-1 :x: compile 0m 18s tez-runtime-internals in the patch failed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07.
-1 :x: javac 0m 18s tez-runtime-internals in the patch failed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07.
-0 :warning: checkstyle 0m 12s tez-common: The patch generated 1 new + 56 unchanged - 0 fixed = 57 total (was 56)
+1 :green_heart: whitespace 0m 0s The patch has no whitespace issues.
-1 :x: javadoc 0m 27s tez-api-jdkUbuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 generated 3 new + 13 unchanged - 0 fixed = 16 total (was 13)
+1 :green_heart: javadoc 1m 38s the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
-1 :x: findbugs 0m 17s tez-runtime-internals in the patch failed.
_ Other Tests _
+1 :green_heart: unit 2m 17s tez-api in the patch passed.
+1 :green_heart: unit 0m 29s tez-common in the patch passed.
-1 :x: unit 0m 18s tez-runtime-internals in the patch failed.
+1 :green_heart: unit 5m 24s tez-dag in the patch passed.
-1 :x: unit 52m 45s tez-tests in the patch failed.
+1 :green_heart: asflicense 1m 17s The patch does not generate ASF License warnings.
151m 58s
Reason Tests
Failed junit tests tez.test.TestAMRecovery
tez.test.TestDAGRecovery
tez.test.TestLocalMode
tez.test.TestFaultTolerance
tez.test.TestSecureShuffle
tez.mapreduce.TestMRRJobs
tez.test.TestTaskErrorsUsingLocalMode
tez.test.TestExceptionPropagation
tez.test.TestPipelinedShuffle
tez.test.TestTezJobs
tez.test.TestRecovery
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-98/4/artifact/out/Dockerfile
GITHUB PR https://github.com/apache/tez/pull/98
JIRA Issue TEZ-4039
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile
uname Linux b66bf5a4b495 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/tez.sh
git revision master / 921de531f
Default Java Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
mvninstall https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-98/4/artifact/out/patch-mvninstall-tez-runtime-internals.txt
compile https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-98/4/artifact/out/patch-compile-tez-runtime-internals-jdkUbuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04.txt
javac https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-98/4/artifact/out/patch-compile-tez-runtime-internals-jdkUbuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04.txt
compile https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-98/4/artifact/out/patch-compile-tez-runtime-internals-jdkPrivateBuild-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07.txt
javac https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-98/4/artifact/out/patch-compile-tez-runtime-internals-jdkPrivateBuild-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07.txt
checkstyle https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-98/4/artifact/out/diff-checkstyle-tez-common.txt
javadoc https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-98/4/artifact/out/diff-javadoc-javadoc-tez-api-jdkUbuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04.txt
findbugs https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-98/4/artifact/out/patch-findbugs-tez-runtime-internals.txt
unit https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-98/4/artifact/out/patch-unit-tez-runtime-internals.txt
unit https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-98/4/artifact/out/patch-unit-tez-tests.txt
Test Results https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-98/4/testReport/
Max. process+thread count 1362 (vs. ulimit of 5500)
modules C: tez-api tez-common tez-runtime-internals tez-dag tez-tests U: .
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-98/4/console
versions git=2.25.1 maven=3.6.3 findbugs=3.0.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

tez-yetus avatar Oct 21 '22 10:10 tez-yetus

:broken_heart: -1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 29s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: test4tests 0m 0s The patch appears to include 2 new or modified test files.
_ master Compile Tests _
+0 :ok: mvndep 5m 48s Maven dependency ordering for branch
+1 :green_heart: mvninstall 10m 1s master passed
+1 :green_heart: compile 3m 49s master passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 :green_heart: compile 3m 39s master passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 :green_heart: checkstyle 3m 24s master passed
+1 :green_heart: javadoc 3m 37s master passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 :green_heart: javadoc 3m 31s master passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+0 :ok: spotbugs 0m 57s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 :green_heart: findbugs 5m 54s master passed
_ Patch Compile Tests _
+0 :ok: mvndep 0m 9s Maven dependency ordering for patch
+1 :green_heart: mvninstall 1m 46s the patch passed
+1 :green_heart: compile 1m 52s the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 :green_heart: javac 1m 52s the patch passed
+1 :green_heart: compile 1m 41s the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 :green_heart: javac 1m 41s the patch passed
-0 :warning: checkstyle 0m 13s tez-common: The patch generated 1 new + 56 unchanged - 0 fixed = 57 total (was 56)
+1 :green_heart: whitespace 0m 0s The patch has no whitespace issues.
-1 :x: javadoc 0m 25s tez-api-jdkUbuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 generated 3 new + 13 unchanged - 0 fixed = 16 total (was 13)
+1 :green_heart: javadoc 1m 35s the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 :green_heart: findbugs 4m 12s the patch passed
_ Other Tests _
+1 :green_heart: unit 2m 17s tez-api in the patch passed.
+1 :green_heart: unit 0m 29s tez-common in the patch passed.
+1 :green_heart: unit 0m 40s tez-runtime-internals in the patch passed.
+1 :green_heart: unit 5m 19s tez-dag in the patch passed.
+1 :green_heart: unit 38m 23s tez-tests in the patch passed.
+1 :green_heart: asflicense 1m 11s The patch does not generate ASF License warnings.
104m 53s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-98/6/artifact/out/Dockerfile
GITHUB PR https://github.com/apache/tez/pull/98
JIRA Issue TEZ-4039
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile
uname Linux a0e3d552e805 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/tez.sh
git revision master / 921de531f
Default Java Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
checkstyle https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-98/6/artifact/out/diff-checkstyle-tez-common.txt
javadoc https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-98/6/artifact/out/diff-javadoc-javadoc-tez-api-jdkUbuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04.txt
Test Results https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-98/6/testReport/
Max. process+thread count 1319 (vs. ulimit of 5500)
modules C: tez-api tez-common tez-runtime-internals tez-dag tez-tests U: .
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-98/6/console
versions git=2.25.1 maven=3.6.3 findbugs=3.0.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

tez-yetus avatar Oct 21 '22 12:10 tez-yetus

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 31s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: test4tests 0m 0s The patch appears to include 2 new or modified test files.
_ master Compile Tests _
+0 :ok: mvndep 5m 56s Maven dependency ordering for branch
+1 :green_heart: mvninstall 11m 6s master passed
+1 :green_heart: compile 3m 56s master passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 :green_heart: compile 3m 38s master passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 :green_heart: checkstyle 3m 26s master passed
+1 :green_heart: javadoc 3m 44s master passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 :green_heart: javadoc 3m 26s master passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+0 :ok: spotbugs 1m 2s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 :green_heart: findbugs 6m 0s master passed
_ Patch Compile Tests _
+0 :ok: mvndep 0m 10s Maven dependency ordering for patch
+1 :green_heart: mvninstall 1m 47s the patch passed
+1 :green_heart: compile 1m 54s the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 :green_heart: javac 1m 54s the patch passed
+1 :green_heart: compile 1m 41s the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 :green_heart: javac 1m 41s the patch passed
+1 :green_heart: checkstyle 1m 17s the patch passed
+1 :green_heart: whitespace 0m 0s The patch has no whitespace issues.
+1 :green_heart: javadoc 1m 38s the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 :green_heart: javadoc 1m 32s the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 :green_heart: findbugs 4m 13s the patch passed
_ Other Tests _
+1 :green_heart: unit 2m 16s tez-api in the patch passed.
+1 :green_heart: unit 0m 29s tez-common in the patch passed.
+1 :green_heart: unit 0m 41s tez-runtime-internals in the patch passed.
+1 :green_heart: unit 5m 19s tez-dag in the patch passed.
+1 :green_heart: unit 42m 54s tez-tests in the patch passed.
+1 :green_heart: asflicense 1m 21s The patch does not generate ASF License warnings.
111m 5s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-98/7/artifact/out/Dockerfile
GITHUB PR https://github.com/apache/tez/pull/98
JIRA Issue TEZ-4039
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile
uname Linux b3a2cfd85cd3 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/tez.sh
git revision master / 921de531f
Default Java Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Test Results https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-98/7/testReport/
Max. process+thread count 1313 (vs. ulimit of 5500)
modules C: tez-api tez-common tez-runtime-internals tez-dag tez-tests U: .
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-98/7/console
versions git=2.25.1 maven=3.6.3 findbugs=3.0.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

tez-yetus avatar Oct 22 '22 12:10 tez-yetus

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 26s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: test4tests 0m 0s The patch appears to include 2 new or modified test files.
_ master Compile Tests _
+0 :ok: mvndep 5m 44s Maven dependency ordering for branch
+1 :green_heart: mvninstall 10m 34s master passed
+1 :green_heart: compile 3m 53s master passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 :green_heart: compile 3m 39s master passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 :green_heart: checkstyle 3m 31s master passed
+1 :green_heart: javadoc 3m 42s master passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 :green_heart: javadoc 3m 24s master passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+0 :ok: spotbugs 1m 2s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 :green_heart: findbugs 6m 17s master passed
_ Patch Compile Tests _
+0 :ok: mvndep 0m 11s Maven dependency ordering for patch
+1 :green_heart: mvninstall 2m 1s the patch passed
+1 :green_heart: compile 2m 17s the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 :green_heart: javac 2m 17s the patch passed
+1 :green_heart: compile 2m 1s the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 :green_heart: javac 2m 1s the patch passed
+1 :green_heart: checkstyle 1m 24s the patch passed
+1 :green_heart: whitespace 0m 0s The patch has no whitespace issues.
+1 :green_heart: javadoc 1m 55s the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 :green_heart: javadoc 1m 45s the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 :green_heart: findbugs 4m 56s the patch passed
_ Other Tests _
+1 :green_heart: unit 2m 19s tez-api in the patch passed.
+1 :green_heart: unit 0m 33s tez-common in the patch passed.
+1 :green_heart: unit 0m 44s tez-runtime-internals in the patch passed.
+1 :green_heart: unit 5m 31s tez-dag in the patch passed.
+1 :green_heart: unit 39m 43s tez-tests in the patch passed.
+1 :green_heart: asflicense 1m 13s The patch does not generate ASF License warnings.
109m 57s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-98/8/artifact/out/Dockerfile
GITHUB PR https://github.com/apache/tez/pull/98
JIRA Issue TEZ-4039
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile
uname Linux c417544f51d0 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/tez.sh
git revision master / 921de531f
Default Java Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Test Results https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-98/8/testReport/
Max. process+thread count 1396 (vs. ulimit of 5500)
modules C: tez-api tez-common tez-runtime-internals tez-dag tez-tests U: .
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-98/8/console
versions git=2.25.1 maven=3.6.3 findbugs=3.0.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

tez-yetus avatar Oct 23 '22 08:10 tez-yetus

Left minor comments.

thanks a lot, fixed in https://github.com/apache/tez/pull/98/commits/01adba3cfca7bbd27d6bbacbbd9bb3041d03ab3cplease let me know if you're fine with them (and my comments)

abstractdog avatar Oct 24 '22 12:10 abstractdog

:broken_heart: -1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 29s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: test4tests 0m 0s The patch appears to include 2 new or modified test files.
_ master Compile Tests _
+0 :ok: mvndep 5m 42s Maven dependency ordering for branch
+1 :green_heart: mvninstall 10m 19s master passed
+1 :green_heart: compile 3m 42s master passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 :green_heart: compile 3m 39s master passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 :green_heart: checkstyle 3m 35s master passed
+1 :green_heart: javadoc 3m 50s master passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 :green_heart: javadoc 3m 39s master passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+0 :ok: spotbugs 0m 58s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 :green_heart: findbugs 5m 46s master passed
_ Patch Compile Tests _
+0 :ok: mvndep 0m 10s Maven dependency ordering for patch
+1 :green_heart: mvninstall 1m 50s the patch passed
+1 :green_heart: compile 1m 51s the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 :green_heart: javac 1m 51s the patch passed
+1 :green_heart: compile 1m 43s the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 :green_heart: javac 1m 44s the patch passed
+1 :green_heart: checkstyle 0m 15s The patch passed checkstyle in tez-api
+1 :green_heart: checkstyle 0m 12s The patch passed checkstyle in tez-common
+1 :green_heart: checkstyle 0m 14s The patch passed checkstyle in tez-runtime-internals
+1 :green_heart: checkstyle 0m 21s tez-dag: The patch generated 0 new + 51 unchanged - 1 fixed = 51 total (was 52)
+1 :green_heart: checkstyle 0m 16s The patch passed checkstyle in tez-tests
+1 :green_heart: whitespace 0m 0s The patch has no whitespace issues.
+1 :green_heart: javadoc 1m 39s the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 :green_heart: javadoc 1m 37s the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 :green_heart: findbugs 4m 16s the patch passed
_ Other Tests _
-1 :x: unit 2m 16s tez-api in the patch failed.
+1 :green_heart: unit 0m 31s tez-common in the patch passed.
+1 :green_heart: unit 0m 40s tez-runtime-internals in the patch passed.
+1 :green_heart: unit 5m 17s tez-dag in the patch passed.
+1 :green_heart: unit 41m 2s tez-tests in the patch passed.
+1 :green_heart: asflicense 1m 18s The patch does not generate ASF License warnings.
108m 18s
Reason Tests
Failed junit tests tez.dag.api.TestTezConfiguration
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-98/9/artifact/out/Dockerfile
GITHUB PR https://github.com/apache/tez/pull/98
JIRA Issue TEZ-4039
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile
uname Linux c970d0135c40 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/tez.sh
git revision master / fc5b6e9df
Default Java Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
unit https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-98/9/artifact/out/patch-unit-tez-api.txt
Test Results https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-98/9/testReport/
Max. process+thread count 1408 (vs. ulimit of 5500)
modules C: tez-api tez-common tez-runtime-internals tez-dag tez-tests U: .
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-98/9/console
versions git=2.25.1 maven=3.6.3 findbugs=3.0.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

tez-yetus avatar Oct 24 '22 14:10 tez-yetus

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 36m 3s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: test4tests 0m 0s The patch appears to include 2 new or modified test files.
_ master Compile Tests _
+0 :ok: mvndep 5m 51s Maven dependency ordering for branch
+1 :green_heart: mvninstall 10m 13s master passed
+1 :green_heart: compile 3m 51s master passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 :green_heart: compile 3m 50s master passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 :green_heart: checkstyle 3m 37s master passed
+1 :green_heart: javadoc 3m 51s master passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 :green_heart: javadoc 3m 36s master passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+0 :ok: spotbugs 1m 3s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 :green_heart: findbugs 6m 0s master passed
_ Patch Compile Tests _
+0 :ok: mvndep 0m 10s Maven dependency ordering for patch
+1 :green_heart: mvninstall 1m 46s the patch passed
+1 :green_heart: compile 1m 54s the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 :green_heart: javac 1m 54s the patch passed
+1 :green_heart: compile 1m 41s the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 :green_heart: javac 1m 41s the patch passed
+1 :green_heart: checkstyle 0m 14s The patch passed checkstyle in tez-api
+1 :green_heart: checkstyle 0m 13s The patch passed checkstyle in tez-common
+1 :green_heart: checkstyle 0m 14s The patch passed checkstyle in tez-runtime-internals
+1 :green_heart: checkstyle 0m 22s tez-dag: The patch generated 0 new + 51 unchanged - 1 fixed = 51 total (was 52)
+1 :green_heart: checkstyle 0m 15s The patch passed checkstyle in tez-tests
+1 :green_heart: whitespace 0m 0s The patch has no whitespace issues.
+1 :green_heart: javadoc 1m 39s the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 :green_heart: javadoc 1m 35s the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 :green_heart: findbugs 4m 12s the patch passed
_ Other Tests _
+1 :green_heart: unit 2m 19s tez-api in the patch passed.
+1 :green_heart: unit 0m 30s tez-common in the patch passed.
+1 :green_heart: unit 0m 39s tez-runtime-internals in the patch passed.
+1 :green_heart: unit 5m 20s tez-dag in the patch passed.
+1 :green_heart: unit 39m 35s tez-tests in the patch passed.
+1 :green_heart: asflicense 1m 18s The patch does not generate ASF License warnings.
142m 58s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-98/10/artifact/out/Dockerfile
GITHUB PR https://github.com/apache/tez/pull/98
JIRA Issue TEZ-4039
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile
uname Linux 7f925c3d5f80 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/tez.sh
git revision master / fc5b6e9df
Default Java Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Test Results https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-98/10/testReport/
Max. process+thread count 1383 (vs. ulimit of 5500)
modules C: tez-api tez-common tez-runtime-internals tez-dag tez-tests U: .
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-98/10/console
versions git=2.25.1 maven=3.6.3 findbugs=3.0.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

tez-yetus avatar Oct 25 '22 10:10 tez-yetus

LGTM. +1

rbalamohan avatar Oct 25 '22 15:10 rbalamohan