Bodor Laszlo

Results 179 comments of Bodor Laszlo

> Can we remove this `cd` and replace with `-pl`and try once? I'm building that docker image in `build-tools/docker` but its taking time. > > ``` > mvn clean install...

ignore my last comment about effective pom, it was wrong, deleted it

hm, strange, now I can repro the same locally too :D ``` mvn -version Apache Maven 3.8.7 (b89d5959fcde851dcb1c8946a785a163f14e1e29) Maven home: /Users/lbodor/Applications/maven Java version: 21.0.8, vendor: Eclipse Adoptium, runtime: /Library/Java/JavaVirtualMachines/temurin-21.jdk/Contents/Home Default...

> > > I'm speculating and might be wrong but is it possible that the `-Dmaven.repo.local=/home/jenkins/jenkins-home/workspace/tez-multibranch_PR-441/yetus-m2/tez-master-patch-0` is gone by the time this ran? > > > ``` > > >...

made a decision here, this PR should be merged, I'm not about to block valuable contributions because we cannot figure out and solve infra problems easily, so in this case:...

this is awesome @Aggarwal-Raghav , thanks! +1

> The goal was to keep the changes at minimum and convert to python3. Otherwise there is scope of improvement in scripts by using `argparser` instead of `sys.argv`, `pathlib` instead...

> @maheshrajus @abstractdog , it seems that the pylint is not working in yetus based on [/branch-pylint-stderr.txt](https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-444/1/artifact/out/branch-pylint-stderr.txt) , As i ran the pylint in local, there are lot of issues...

patch looks good to me now, thanks @Aggarwal-Raghav, I'm merging this soon can you please create a follow-up for the pylint issue?