Bodor Laszlo

Results 179 comments of Bodor Laszlo

> @abstractdog , what you said above is correct but as per my understanding, schematool will launch 1 jvm which will have embedded HS2 and HMS and based on the...

> Yes, that is correct. After setting the `hive.hook.proto.base-directory `, i found another issue, which I filed under [HIVE-29012](https://issues.apache.org/jira/browse/HIVE-29012) but even after the potential fix in the respective PR, I...

> > > Yes, that is correct. After setting the `hive.hook.proto.base-directory `, i found another issue, which I filed under [HIVE-29012](https://issues.apache.org/jira/browse/HIVE-29012) but even after the potential fix in the respective...

> bin/schematool -dbType hive -metaDbType derby -initSchema nice repro! yes, this is what we hit downstream too

> ## [![Quality Gate Passed](https://camo.githubusercontent.com/f7c890f34e0efe8252e17e9afd5a85aa22fc9c81b42a0ec3d4821af9f55f250d/68747470733a2f2f736f6e6172736f757263652e6769746875622e696f2f736f6e6172636c6f75642d6769746875622d7374617469632d7265736f75726365732f76322f636865636b732f5175616c6974794761746542616467652f71672d7061737365642d323070782e706e67)](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=6161) **Quality Gate passed** > Issues ![](https://camo.githubusercontent.com/187ba88c264795e888bdd18141ef29390601e5110d4e9c8cc48f2f8afc183ba0/68747470733a2f2f736f6e6172736f757263652e6769746875622e696f2f736f6e6172636c6f75642d6769746875622d7374617469632d7265736f75726365732f76322f636f6d6d6f6e2f7061737365642d313670782e706e67) [2 New issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=6161&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true) ![](https://camo.githubusercontent.com/86e5c40907bf9e8933fe6bcf185f7076622a76a3bef4b6d2b5fd583959409aef/68747470733a2f2f736f6e6172736f757263652e6769746875622e696f2f736f6e6172636c6f75642d6769746875622d7374617469632d7265736f75726365732f76322f636f6d6d6f6e2f61636365707465642d313670782e706e67) [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=6161&issueStatuses=ACCEPTED) > > Measures ![](https://camo.githubusercontent.com/187ba88c264795e888bdd18141ef29390601e5110d4e9c8cc48f2f8afc183ba0/68747470733a2f2f736f6e6172736f757263652e6769746875622e696f2f736f6e6172636c6f75642d6769746875622d7374617469632d7265736f75726365732f76322f636f6d6d6f6e2f7061737365642d313670782e706e67) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=6161&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true) ![](https://camo.githubusercontent.com/187ba88c264795e888bdd18141ef29390601e5110d4e9c8cc48f2f8afc183ba0/68747470733a2f2f736f6e6172736f757263652e6769746875622e696f2f736f6e6172636c6f75642d6769746875622d7374617469632d7265736f75726365732f76322f636f6d6d6f6e2f7061737365642d313670782e706e67) [0.0% Coverage on New...

thanks @deniskuzZ , @Aggarwal-Raghav for the reviews! restarted test to have a green precommit, then I'll merge

test failures are related, need a bit of rework before the next patch

> Is the credentials fix - the one Kokila pointed out going in before further merge? Otherwise looks good yes, tried to clarify this in code comments, but let me...

@deniskuzZ: your comments were addressed in https://github.com/apache/hive/pull/4882/commits/c84f536c64cf6b298109473c363434d7acbf816e

> LGTM, some minor stuff thanks! addressed in https://github.com/apache/hive/pull/4882/commits/506c55d07c7e6f761c1295bfcdd6e6ec4d1c1f1e