Andrew Brown

Results 257 comments of Andrew Brown

You can tag me once you're ready for review; I glanced over this and it made sense.

> Because of this I think for example adding two vectors is broken I think this is only broken if you turn on the `enable_simd` setting because only a handful...

cc: @pchickey, @sunfishcode, @alexcrichton, @jedisct1

> maybe we really need code generators (not only for Rust) that we could all use @jedisct1, is [witx-codegen](https://github.com/jedisct1/witx-codegen) an attempt to fix this problem? I haven't tried it out...

Ok, I tried it and I get the following when attempting to compile in the generated code which includes a `tensor.as_ptr()`: ``` the following trait defines an item `as_ptr`, perhaps...

Here is the generated output from [wasi-nn](https://github.com/WebAssembly/wasi-nn/blob/a39bee077599ffa9ac3299def3d1bd8dd4083c10/phases/ephemeral/witx/wasi_ephemeral_nn.witx): [edit: hidden to avoid taking up the whole page] ``` // This file is automatically generated, DO NOT EDIT // // To regenerate...

Maybe it should be `src.push_str(" as *mut _");` instead of `src.push_str(".as_ptr()");`?

@pchickey, I was able to get past this using `src.push_str(" as *const _ as *mut _")`. Then I ran into issues with lifetimes: `witx-bindgen` printed `Tensor` when it needed to...

The wasi-parallel interface was designed under the assumption that there would be _some_ way to express (e.g., interface types, component model, etc.) that the API must receive a "function" to...