Abrar Ahmad
Abrar Ahmad
> Is the label because this is still WIP? Yes, I'm making some changes to the tests. I'll remove the label once I've done.
@stancl I gave it a final review now. I replied to all of the reviews. I removed two tests because other tests are kind of doing the same. Please check...
> FYI you can create branches in this repo for simple PRs. It would work better because then I could check out this branch and easily make changes in it....
> That's with the GitHub CLI, right? I think GitHub CLI can do that too, but I often use GitHub Desktop.
> we're using the creation attributes for both the central model and the tenant model, right? Yes correct. > Are the creation attributes defined separately on the central model and...
> @abrardev99 There's still this: > > > Note: Implementation has been changed. See PR reviews. I'll update the description when resolved all the reviews. > > in the PR...
> A note about code style — try to write code that follows our code style on your own, don't depend on php-cs-fixer fixing your code. It should just catch...
>Keep the property name $batchRepository Since we're using dependency injection, we shouldn't be using the DB:: facade in the code. Use DI for that as well. It should be something...
@mpociot just curious is the project abandoned?
Can we make headings clickable in `v4`? It's actaully just wrapping them in `a` tag. I see almost all headings have the `id` attribute so that we can use `id`...