Abrar Ahmad
Abrar Ahmad
> ready for final review now? And are all of my comments above addressed? Some are now collapsed in the "x hidden comments." Yes, all the comments are addressed and...
Updated > **Note**: I merged the `3.x` branch into this PR to resolve the conflicts. ## Dockerfile I've rewritten the Dockerfile and used the **node** container as the base and...
> Are all of these three points solved? https://github.com/archtechx/tenancy/pull/793#issuecomment-1167829755 All of the points are completed, but I'm not sure about `2`. I think the cache key is unique based on...
> could you also fix the missing health check in docker-compose.yml? I don't think `docker-compose.yml` has a missing health check in this branch.
> The missing healthcheck is in 3.x I think. It's not in `3.x` either. It's in the `master` branch where `mssql` changes got merged, and I think only `mssql` has...
Did you see my reply to the review? I explained there. https://github.com/archtechx/tenancy/pull/793#discussion_r931897332
I see. So then, we can use the "matrix" config with different Laravel and PHP versions.
> Is this implemented now? Not yet. > can we change the target to master? I'd rather make this change as part of v4. Yes, we can make it to...
> Is this implemented now? It's got implemented.
@stancl The checks are failing. Looks like `master` got some [changes](https://github.com/archtechx/tenancy/blob/master/src/Enums/LogMode.php) like `enum`, which works only on PHP `8.1`. So we can't really test below `8.1`. So now, checks pass...