Andrei Botalov

Reserved characters aren't allowed in query string when matching it against template

5

``` ruby Addressable::Template.new('{?a}').match(Addressable::URI.parse('?a=b,c')) # => nil ``` It seems to me that comma is allowed symbol in query. At least the following works: ``` ruby Addressable::URI.parse('?a=b,c').query # => 'a=b,c' ```

Default variable values seem to be not supported by Template

2

RFC6570 doesn't seem to have a concept of default values. But `Template` class has `variable_defaults` method so I would expect it it to work the same as here - http://msdn.microsoft.com/en-us/library/bb675245(v=vs.110).aspx...

Equal urls are removed when parsing

2

Here is a test HTML file: ``` html Google Google ``` and test ruby code: ``` ruby bookmarks = Markio.parse(File.open(filename)) urls = [] bookmarks.each do |b| urls

* Invalid host (without /api/v1) * invalid config (= instead of :) https://reportportal.slack.com/archives/C2GTZU8N5/p1566506191114700

Rubocop was introduced in https://github.com/reportportal/agent-ruby/pull/43. We should address TODOs one by one - create a PR per one / several offenses to ease reviewing. - [x] Layout/AlignArguments - [ ]...