Adam Boniecki

Results 113 comments of Adam Boniecki

@T-Gro did some experiments using the built in VsTask, abandoned here https://github.com/dotnet/fsharp/pull/17765/files .

> This PR fixes it by making sure that all code paths of the statically optimized string call **will not return an empty string**. This was supposed to say "will...

@ncave Could you please share code that repros this?

I mean specifically how does this case looks like > - Seems to be missing a case where an union case tester method is neither IsProperty nor IsMethod (but it...

@ncave sorry I got a bit sidetracked last couple of days. I guess I wanted to know what F# code you are inspecting that results in `IsProperty = false`, `IsMethod...

Right @ncave, sorry for being a little clueless here, but I can't figure out how you're grabbing the `get_IsCustom` symbol that makes this combination of `IsMethod = false` and `IsPropertyGetterMethod...

I've started with that (it's IsMethod = false, IsPropertyGetterMethod = false). Is it possible for you to share the code that runs into IsMethod = false, IsPropertyGetterMethod = true? I...

Thanks @ncave, I can reproduce this now. I suspect this is a bug in these properties (and not in the `IsUnionCaseTester`) - it doesn't make sense that it would be...

@akoeplinger what you mentioned above is a fix on arcade's side I assume? Because replacing references to `MicrosoftVSSDKBuildToolsVersion` with `MicrosoftVSSDKBuildToolsPackageVersion` on our side doesn't seem to affect this issue

Thanks @zivkan , this has worked and since we had external contributors complaining about working with our sln I merged this temporary fix https://github.com/dotnet/fsharp/pull/19106, but it would great to see...