Adam Boniecki

Results 113 comments of Adam Boniecki

For the second one, here is difference in allocations from calling the first version of the function vs. the second one 1k times in a loop. Using concat: ![image](https://github.com/dotnet/fsharp/assets/20281641/9923f894-7993-4206-b208-c7ae26b06f1e) vs....

> the PR only works when the inner expressions are strings only. That is not the majority case. That is true. This issue is specifically about lowering to `System.String.Concat` and...

I am looking into this now. It does indeed seem to be the same issue as #9631. As far as I can tell so far, it happens when an exception...

I've started looking into this. It is tricky because we turn double braces into single braces during lexing already. At the point where we generate `FormattableStringFactory.Create` call, there is no...

Even worse, I discovered this: ```fsi > let str = $"{{0}}+{42}" : System.FormattableString;; val str: System.FormattableString = 42+42 > str.Format;; val it: string = "{0}+{0}" ```

I've just noticed that this is still not fixed despite my PR, will have to investigate edit: not sure what exactly is going on, but even though the added unit...

@mrange Yes, if you get the preview version of dotnet sdk, it's already there, but for under `--langversion:preview` flag

We want to avoid the breaking change here, so this needs to keep working with the `.()` operator. @auduchinok do you want to update this PR to account for that?

Doing clean up in PRs - please reopen if you deem appropriate

Closing since the same functionality is already available as an analyzer