Austin Bonander comments

Results 748 comments of


                                            Austin Bonander

Sqlite EXPLAIN type inference improvements

Changes to null inference are potentially a breaking change and so this will need to wait for 0.7.0.

[question] Convert errors to user friendly errors

This is perhaps _slightly_ better: ```rust match e { sqlx::Error::Database(e) if e.column_name() == Some("email") => { UserError::EmailTaken } _ => UserError::General(e), } ``` I think we could stand to improve...

[question] Convert errors to user friendly errors

Oh, it might be `e.constraint_name() == Some("email_unique")` or something like that. You can switch it back to matching on the error code if you find that more reliable.

Regression in v0.6 when decoding an PostgreSQL enum in a PgRecordDecoder

Unfortunately, I think that's just going to bring back the panic in the array decode case, which you yourself reported in #1672.

Fix compile time verification performance regression for sqlite

Do you mind looking at the failing CI checks?

Fix compile time verification performance regression for sqlite

@liningpan do you have time to address the CI failures I mentioned before? The logs are gone now but if you amend your commit to update the SHA and push...

Fix compile time verification performance regression for sqlite

Yeah, sorry. It's easy to get sidetracked and forget about PRs in the queue. I don't even have the "Approve and Run" button anymore though, you'll need to update the...

Fix compile time verification performance regression for sqlite

@liningpan @tyrelr is it possible for this PR to cause type/null inference changes?

UNION not supported?

@felixwatts what database are you using?

Implement `Type` for `[u8; N]`

This will be part of 0.6