sqlx icon indicating copy to clipboard operation
sqlx copied to clipboard

Sqlite EXPLAIN type inference improvements

Open rongcuid opened this issue 3 years ago • 4 comments

Fixes #1983.

  • [x] No longer complains about ROW_NUMBER type being null
  • [ ] Supports all window functions that returns integer

Feel free to merge if repo maintainer thinks this is a good first step.

rongcuid avatar Jul 18 '22 13:07 rongcuid

I think I have all the aggregates described here: https://www.sqlite.org/windowfunctions.html#introduction_to_window_functions

I am not using them, so I am not testing those.

rongcuid avatar Jul 18 '22 13:07 rongcuid

What does it mean by failing to format? I don't see any output in the checks.

rongcuid avatar Jul 20 '22 22:07 rongcuid

https://github.com/launchbadge/sqlx/runs/7438234746?check_suite_focus=true

Just run cargo fmt and commit.

abonander avatar Jul 20 '22 23:07 abonander

Can someone check and merge this? I have another PR I want to submit later.

rongcuid avatar Jul 25 '22 20:07 rongcuid

Changes to null inference are potentially a breaking change and so this will need to wait for 0.7.0.

abonander avatar Sep 13 '22 00:09 abonander

PR target changed to the 0.7 development branch.

abonander avatar Sep 15 '22 00:09 abonander

@rongcuid can you push another commit to trigger another CI run? Amending and force-pushing your last commit to update the SHA should be sufficient. I'm now working on 0.7.0 so this will be merged soon.

abonander avatar Sep 15 '22 01:09 abonander

What's going on? How do I make it pass?

rongcuid avatar Sep 20 '22 23:09 rongcuid

If you rebase on 0.7-dev it should fix those.

abonander avatar Sep 20 '22 23:09 abonander