abma

Results 101 comments of abma

> We have but 1 issue. If Shards C++ implementation uses a submodule, will that be pulled in via the engines build process, and the submodules inside that. Or will...

i don't understand your plan. i only know about "split into submodules" but there are IMHO more reasons against doing that then reasons for doing that.

> will it pull in the submodules no, it requires a lot of changes to the build scripts. also all build instructions are missing the --recursive parameters. > will this...

> Where would one begin in order to implement that? https://github.com/Tarendai/Shard/blob/master/CMakeLists.txt#L10 example: https://github.com/spring/spring/blob/develop/tools/CMakeLists.txt#L5 i don't see alternatives to cmake which make sense as they would require a new tool.

i've reverted this in spring's fork: https://github.com/spring/Shard submodules cause a lot more problems than they solve.

> What did you revert? None of the changes discussed here were ever made because i don't want to break it a second time i "removed" the submodles.

just use a single git repository and no submodules. KISS! (!!!!)

submodules are a mess: - cloning spring + submodules takes much longer the more submodules it has - its much more error error-prone: external repositories can disappear - there is...

weird, from what i read here, bots should be kept forever: https://github.com/spring/uberserver/blob/e63fee427136e5bafc1b20c8c984a5c348bc6624/SQLUsers.py#L692

are you sure the user account had the botflag set?