Adam Black
Adam Black
The direction I've been trying to go in is to use DBI as much as possible. DatabaseConnector::connect() is essentially the same function as DBI::dbConnect(). The only difference is how the...
Great! I suggest adding it to the end of the Connect.R file [here](https://github.com/OHDSI/DatabaseConnector/blob/b3d3162711aad954c3eb649751544c7a3d01455c/R/Connect.R#L694). It will need Roxygen comments and the NAMESPACE file will need to be updated by running devtools::document()....
Looks good to me! Next I'd say you should add unit test for the function. I think I'd add it to the bottom of the [test-connection.R file](https://github.com/OHDSI/DatabaseConnector/blob/b3d3162711aad954c3eb649751544c7a3d01455c/tests/testthat/test-connection.R#L249) (I'm thinking we...
> We may want to think about giving each DBMS its own `createConnectionDetails` function, with arguments specific to that DBMS? So `createConnectionDetailsBigQuery()`, `createConnectionDetailsSqlServer()`, etc. My proposal is to use DBI::dbConnect()...
Here is the script I source whenever I connect to bigquery using DatabaseConnector. Huge thanks to Jose for writing it. I think it'd be great to add to DatabaseConnector because...
so I think we would indeed piggy back of the [SQL server backend ](https://github.com/tidyverse/dbplyr/blob/main/R/backend-mssql.R)but only for Sql server. We would use the [postgres backend](https://github.com/tidyverse/dbplyr/blob/main/R/backend-postgres.R) for postgres Etc. for the other...
Yea it's hard to explain on github. Here is the PR which might help https://github.com/OHDSI/DatabaseConnector/pull/258. Basically we would like to use DatabaseConnector as a database driver only and use dbplyr...
Yes that is correct. I'm just extending your initial approach to other dbms and removing the need for the sqlrender::translate step. I haven't tested this much yet though so I...
Ok great! Yes please create a separate branch for me to target with my pull request. I'll do a bit more testing and make sure the fork is working as...
May I have the ability to push directly to the OHDSI/DatabaseConnector:dbplyr_backends branch? This would help becuase then the full set of tests will run on my PR. If I make...