Adam Black

Results 122 comments of Adam Black
trafficstars

I'd also like to suggest adding person_id and possibly a date field to the cost table. [Cost is considered a domain](https://athena.ohdsi.org/search-terms/terms?domain=Cost&page=1&pageSize=15&query=) (or at least there is a domain_id = "COST")....

Closing this due to no response or activity after 5 months.

> I was unaware of `fs::path_package` adding this into `SqlRender` directly may fix this issue in place of `system.file`. You could also try `pkgload:::shim_system.file()` in `loadRenderTranslateSql` which should work with...

Good point. Does anyone have a use case that requires this change?

Ok good to know. How does the proposal triage process work?

Also apparently users are a bit confused about the meaning of "visit type" so it would be helpful to provide some text to cue them to the meaning of visit...

Yea I see your point @gklebanov. It seems like it would be odd to use the visit type concepts in a cohort definition that is supposed to work across CDMs...

So are type concepts something we want people using in cohort definitions? I does seem a bit strange to say "I want drug X that comes from an insurance claim"...

I don't understand why we need java to run the cohort diagnostics shiny app. Querying sqlite from R does not require java. We shouldn't need to use sqlrender to translate...

Ah ok. Do you support multiple database backends for the shiny app? Yea I have not been able to reproduce the error either but I know more than one person...