Abhishek Srivastava

Results 8 comments of Abhishek Srivastava

This PR should be merged. Thank you for the gem.

Not able to get anything done because of this issue, although API wrapper looks quite full fledged :(

If I am not wrong I have to use the front matter from here and add the priority - https://github.com/jekyll/jekyll-sitemap/blob/99148a2255a2b3a8d2b31ba8216945262981b12c/lib/sitemap.xml#L20

PDF js files are heavy and using CDN would improve the performance. https://github.com/mozilla/pdf.js#including-via-a-cdn ![mozilla_pdf_js__PDF_Reader_in_JavaScript](https://user-images.githubusercontent.com/749134/89855070-1f5c6800-dbb3-11ea-8e55-71f7cb5e856d.jpg)

Hi, upon further investigations I can see assets on which `stylesheet_link_tag` [eg](https://github.com/senny/pdfjs_viewer-rails/blob/e29b6e30d087d3c6eb530d6e877c229a03e52471/app/views/pdfjs_viewer/viewer/_head.html.erb#L4) is used are setting the `cache-control` headers correctly but assets which are linked directly do not set any...

WIP - https://github.com/abhishek77in/HackerNotes/tree/feature/extention-installation

Chrome plugin prompt implemented - https://github.com/abhishek77in/HackerNotes/commit/38e95720f4ba3a51b5d2a17f3f8e785e68627763