Abhishek Ram

Results 51 comments of Abhishek Ram

That is interesting, it should not be throwing an exception. It should not have allowed you create the partner. When creating the public cert with validation what all did you...

Why not just define this logic in the post receive command? Create a post receive script `post_as2_message_receive.py` which would be something like ```python #!/usr/bin/env python3 import requests payload = dict(...

It would be part of your repo so I don't see it as an external script. I dont see a reason to implement callbacks as it can be handled in...

I think we need to remove the unique together for message_id and partner. If not when there is a failed message and then its retries it would cause integrity error...

So I guess I was wrong and it wont fail because I am doing an update or create in `create_from_as2message` method. But in essence it would update the existing message...

It is not optional, I guess I need to raise validation error here.

For security reasons a password needs to be set for a private key. You should be able to add it like so https://security.stackexchange.com/questions/59136/can-i-add-a-password-to-an-existing-private-key

I think this is a good idea but from my experience changing partner certificates is not a big deal. It may be more useful to think of solutions for managing...

Here are my thoughts on this @chadgates ### Simple Approach (django-pyas2 only) * Add new fields - signature_key_alt, encryption_key_alt to the Organization model. * **When receiving the message** * Try...

Is there more to the exception here because I cannot see the django-pyas2 code anywhere in this exception