Antoine BERNIER

Results 34 comments of Antoine BERNIER

@Mugen87 About formatting, is there a tool to run against my code? Thank you Ok, found the `eslint` tooling

✅ ok, all my tasks are now complete if you want to review @Mugen87 ;)

About [the screenshot](https://github.com/mrdoob/three.js/pull/24652/files#diff-5e27fa5e8c8e7cb05b87e2b39278ba20034292638848aeba01af971827ba6385), I've initially and naively generated it manually... ![webgl_animation_skinning_ik](https://user-images.githubusercontent.com/76580/190923218-9cebd346-d716-4c9a-92a9-83308a493b00.jpg) Since I've checked on [this failed CI task](https://github.com/mrdoob/three.js/actions/runs/3077854300/jobs/4973008639) and now I understand it is supposed to be auto-generated to...

> > Is there a way to delay the moment the screenshot is taken? (in my case 2.5s may be enough) > > Currently no (will be fixed in #24109)....

ok, let me simplify it extremely...

@Mugen87 ok, I've drastically simplified it, in the spirit of an IK example, leaving only the essential. It's maybe less appealing, but it should better fit examples' requirements: https://abernier.name/three.js/examples/#webgl_animation_skinning_ik I've...

> It's quite easy to "break" the example by translating the sphere along the x-axis. The result is an endless ping-pong effect Indeed, I think this is due to `rotationMin`/`rotationMax`...

> Let's use `transformControls.showX = false;` for now. That should mitigate the most obvious glitches. I will add it tomorrow + some tweaks on the glb and will mark the...

ok - [x] `showX=false` - [x] fixed broken link - [x] updated screenshot https://abernier.name/three.js/examples/#webgl_animation_skinning_ik lgtm, but don't hesitate if anything else I can do

> it is necessary to define a license for `kira.glb` How should I proceed for this?