adrian berindei

Results 5 comments of adrian berindei

Datasheet says that the interface must be enabled (BCM2708_I2S_EN = 1), but to modify regs not running (BCM2708_I2S_TXON = 0 and BCM2708_I2S_RXON = 0) and some clock running to wait...

I have to disagree. This https://github.com/koalo/linux/blob/rpi-3.8.y-asocdev/sound/soc/bcm2708/bcm2708-i2s.c#L268 is wrong. And I also think that clearing FIFOs should be done per stream to not disrupt first one when the second is opened....

And yes you are also right that wont work (the interface will be running). Ideally would be nice to reset the fifos every time when we start a stream but...

I am not saying that fullduplex is wrong.I also prefer that to have this functionality. The only reason was that I placed it after this https://github.com/koalo/linux/blob/rpi-3.8.y-asocdev/sound/soc/bcm2708/bcm2708-i2s.c#L373 so was called only...

I think this is good point.It will be keeping the hardware in sync especially for 32 bit samples.I will test that.