Abenet Tamiru

Results 11 comments of Abenet Tamiru

> I think this component may benefit from splitting the `$format` prop into one specifically for the `datetime` attribute of ``, and another format for what we want the user...

I like the idea of the four components, it makes what is supposed to happen more explicit. Also, as we're a laravel package it can be presumed that the user...

Using separate components also lets us implicitly know the format of the `datetime` property. We might want to allow the user to override the format but a default one can...

I think it it would be good to use the default color type for the component, this would not only be semantically correct it would also remove another dependency.

I feel like that in most cases the default color picker is sufficient, maybe we can implement the native color picker as the default and use `Pickr` as an optional...

Of course, but these versions are also unsupported for a reason, plus it helps move the community forward™. Also Laravel 9 is going to be an LTS release which means...

I see the BC concern but I also feel like when I'm manipulating a set I want it to behave like a set. Maybe this can be merged into a...

I see your point about not introducing a `$collection` property but I found the `map` implementations too similar to override them, alternatively one could in the `AbstractCollection` create a `new...

I would argue so yes, when I create a new `Set` I expect it to behave a certain way and until I explicitly say make this `Set` into a `Collection`,...

You're right that would be even better! In your snippets you're using the `Env` Enum, I would actually like to avoid that and use a simple string to give people...