Mohamed ABDELLANI
Mohamed ABDELLANI
I noticed that when I access the report page for the first time after clicking a link from the reports list, the backend generates the report even if nothing is...
Hi @dacook The data fetched from the database is not used. I wouldn't consider it as a problem if the queries don't impact the production server performance.
@dacook > it runs the report (query the database) based on the default form parameters. Yes, you're right. >That doesn't sound good, but if it's not a problem, then I...
Hi I was not able to reproduce the problem. The screenshot shows the third attempt to import your file.  Also, I couldn't see any problem with the product table....
Yes @RachL . You can assign it to me now : )
Here's what I found so far. When I tried to create an invalid product with the unit_value = 700, the value was converted to 699.9999999999999 at the view level. When...
I found a problem at the controller level: https://github.com/openfoodfoundation/openfoodnetwork/blob/master/app/assets/javascripts/admin/products/controllers/units_controller.js.coffee#L39 When the controller initializes the visible `value` field in the form (`unit_value_with_description`), The code devises the unit_value by the unit_scale. -...
Hi It seems that floating number precision problem is not only in the product creation form, it's also in the import function:  I imported [test-weirdo4.csv](https://github.com/openfoodfoundation/openfoodnetwork/files/9926876/test-weirdo4.csv)    This...
Hi The second part of the problem is in the [Unit Convert](https://github.com/openfoodfoundation/openfoodnetwork/blob/master/app/models/product_import/unit_converter.rb#L64) used in the product imported. ``` [2] pry(#)> @attrs['units'] => "701" [3] pry(#)> @attrs['variant_unit_scale'] => 0.001 [4] pry(#)>...
I failed to reproduce the problem https://user-images.githubusercontent.com/16113997/197142907-1923f660-0b58-4262-9ab7-a89b364731b4.mp4