Christian Abbott comments

Results 8 comments of


                                            Christian Abbott

Multiple calls to prepare_recipe() within SimpleTestCase fails when recipe uses seq()

Hi @berinhard, Thanks for following up on the issue and for the detail in explaining the rationale behind the query that gets executed in this scenario. If you'd like me...

Multiple calls to prepare_recipe() within SimpleTestCase fails when recipe uses seq()

Thanks, the PR is up.

Multiple calls to prepare_recipe() within SimpleTestCase fails when recipe uses seq()

@berinhard Also, thinking about what you explained regarding the query led me to consider other issues related to that which could be considered less minor than this issue, and I've...

Calling prepare_recipe before make_recipe on a Recipe with a seq gives both records the same seq value

Having thought over this some more, I keep coming to the conclusion that a custom test runner is the best solution, although I know that option had been considered already...

Calling prepare_recipe before make_recipe on a Recipe with a seq gives both records the same seq value

Hi Tim, Thanks for the detailed response, and thanks for being an open source maintainer. Yes, I can write a PR for this. I'll wait though until hearing from the...

MoneyField as an output_field from django expressions?

It looks like the reason this doesn't work is because `MoneyField` doesn't define `from_db_value`. I don't know if the developers of this project expressly refrained from implementing that method. Perhaps...

Remove apparently obsolete FilterMixin metaclass

Sure I can take care of them. What else needs to be cleaned up? Or are all of them marked with a clear `TODO` like this one that would make...

Consider better-supported html entity for icon to remove stop

Also, another option could be to include it as SVG, which for reference, is: