Alexander Batishchev

Library should include both Json.Net and System.Text.Json serialziers

7

After the recent changes, it includes one or another. @hartmark we've made it too opinionated: either one or another. How about somehow allow both options on the platform whether that's...

Things to include; Issue: - Version - Exception message, stack trace Pull request: - Link to issue - Summary of changes - Breaking change notice - Test added - Version...

Split NuGet package into few child packages to ease dependencies

14

The idea is to extract few child packages: - JwtNet.Json.NewtonSoft for JsonNet based implementation of Json (de)serialization - JwtNet.Json.ServiceStack for ServiceStack.Text based implementations - JwtNet.Cryptography.RS256 for System.Security.Cryptography based implementation of...

Added .idea/ to VisualStudio.gitignore

2

**Reasons for making this change:** Added folder `.idea` which is created by the JetBrains Rider IDE for .NET projects. See https://rider-support.jetbrains.com/hc/en-us/articles/207097529-What-is-the-idea-folder-

Let files in ImageStore to be downloaded to allow deployment troubleshooting

10

Kind of a follow-up on https://github.com/Azure/service-fabric-issues/issues/6. Currently there is a way to [list directories and files](https://docs.microsoft.com/en-us/powershell/module/servicefabric/get-servicefabricimagestorecontent?view=azureservicefabricps) within cluster's image store but there is no way to download these files back...

Update service-fabric-reliable-services-reliable-collections-guidelines

2

- Replaced `time-out` with `timeout` - Replaced `four` with `4`

Type in response is random string instead of ARM resource type

2

Given an example: ```json { "operationId": "Categories_Update", "title": "Categories_Update", "parameters": { "api-version": "2022-06-01-preview", "subscriptionId": "00000000-0000-0000-0000-000000000000", "resourceGroupName": "rgthrottling", "accountName": "aaaaaaaaaaaaaaaaaaaaaaaaaaa", "categoryName": "aaaaaaaaaaaaaaaaaaaaaaaaa", "properties": { "properties": { "windowDuration": "PT5M" } } },...

Example for DELETE doesn't need both Min and Max set

2

Currently generated examples include bothMinimumSet and MaximumSet for all verbs. But those for DELETE appear to be always identical. At least provide an option to customize the behavior.

Random input for SubscriptionId is a string, not a guid

2

Common Types v3 unfortunately defines the `SubscriptionIdParameter` as just a string of min length 1: https://github.com/Azure/azure-rest-api-specs/blob/77b673c60d3efe1bc9cb30525db176e67b8d24dd/specification/common-types/resource-management/v3/types.json#L622-L629 So sample input is just a string too: ```json { "parameters": { "api-version": "2022-06-01-preview",...