Andrew Barr

Results 11 comments of Andrew Barr

Hi, I will have a look at this (As per email). I am happy for yuo to assign it to me if you like. Andrew

Hi Kelvin, I have been looking through the code. Without testing it looks like: 1. Remove :`tenant_prefix` from the Config module 2. Update `Triplex.to_prefix(tenant, prefix \\ config().tenant_prefix)` to remove the...

Hi, I will also create a separate issue for the addition of `Triplex.migrate_all` Andrew

Got it. Thanks I will go back and look again. Andrew

Hi Kelvin, I am new to contributing to open source ... will you merge the pull request with `master` and then if you are happy bump the version number and...

Hi Kelvin, I have gone back through the code: ``` def to_prefix(tenant, prefix \\ config().tenant_prefix) def to_prefix(tenant, prefix) when is_map(tenant) do tenant |> tenant_field() |> to_prefix(prefix) end def to_prefix(tenant, nil),...

Hi Kelvin, I made the following changes based on our previous discussion: ``` def all(repo \\ config().repo) do sql = case repo.__adapter__ do Ecto.Adapters.MySQL -> "SELECT name FROM #{config().tenant_table}" Ecto.Adapters.Postgres...

Hi Kelvin, I have been thinking about my comment above. It makes sense that the `MySql` functionality works in the same way as the `Postgres` code. When you get a...

Hi Kelvin, Just checking in to make sure I have resolved the requested changes properly ... if not please let me know ... otherwise I expect you have been busy....

Hi Rob, I have been learning Elixir and thought I might try Moebius. I saw this issue and thought I might try to help (This is the first time I...